ethtool: fix drvinfo strings set in drivers

Use strlcpy where possible to ensure the string is \0 terminated.
Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
and custom defines.
Use snprintf instead of sprint.
Remove unnecessary inits of ->fw_version
Remove unnecessary inits of drvinfo struct.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 3 deletions

diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c
index 18d9579123ea..8d5cac2d8e33 100644
--- a/drivers/net/usb/catc.c
+++ b/drivers/net/usb/catc.c
@@ -685,9 +685,9 @@ static void catc_get_drvinfo(struct net_device *dev,
                              struct ethtool_drvinfo *info)
 {
         struct catc *catc = netdev_priv(dev);
-        strncpy(info->driver, driver_name, ETHTOOL_BUSINFO_LEN);
-        strncpy(info->version, DRIVER_VERSION, ETHTOOL_BUSINFO_LEN);
-        usb_make_path (catc->usbdev, info->bus_info, sizeof info->bus_info);
+        strlcpy(info->driver, driver_name, sizeof(info->driver));
+        strlcpy(info->version, DRIVER_VERSION, sizeof(info->version));
+        usb_make_path(catc->usbdev, info->bus_info, sizeof(info->bus_info));
 }
 
 static int catc_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)