diff options
author | Eric Dumazet <edumazet@google.com> | 2013-08-08 17:38:47 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-08-10 04:16:44 -0400 |
commit | 28d6427109d13b0f447cba5761f88d3548e83605 (patch) | |
tree | 5f463fa756d508625e8cea1da31406e66a0b263e /drivers/net/tun.c | |
parent | e370a7236321773245c5522d8bb299380830d3b2 (diff) |
net: attempt high order allocations in sock_alloc_send_pskb()
Adding paged frags skbs to af_unix sockets introduced a performance
regression on large sends because of additional page allocations, even
if each skb could carry at least 100% more payload than before.
We can instruct sock_alloc_send_pskb() to attempt high order
allocations.
Most of the time, it does a single page allocation instead of 8.
I added an additional parameter to sock_alloc_send_pskb() to
let other users to opt-in for this new feature on followup patches.
Tested:
Before patch :
$ netperf -t STREAM_STREAM
STREAM STREAM TEST
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
2304 212992 212992 10.00 46861.15
After patch :
$ netperf -t STREAM_STREAM
STREAM STREAM TEST
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
2304 212992 212992 10.00 57981.11
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tun.c')
-rw-r--r-- | drivers/net/tun.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/tun.c b/drivers/net/tun.c index b1630479d4a1..978d8654b14a 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c | |||
@@ -949,7 +949,7 @@ static struct sk_buff *tun_alloc_skb(struct tun_file *tfile, | |||
949 | linear = len; | 949 | linear = len; |
950 | 950 | ||
951 | skb = sock_alloc_send_pskb(sk, prepad + linear, len - linear, noblock, | 951 | skb = sock_alloc_send_pskb(sk, prepad + linear, len - linear, noblock, |
952 | &err); | 952 | &err, 0); |
953 | if (!skb) | 953 | if (!skb) |
954 | return ERR_PTR(err); | 954 | return ERR_PTR(err); |
955 | 955 | ||