aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/tulip
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2007-09-15 17:41:06 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-10-10 19:51:17 -0400
commit88d3aafdae5c5e1d2dd9489a5c8a24e29d335f2e (patch)
tree272ce75c30a170420ac8bbfd679c3faed9f9d20a /drivers/net/tulip
parent09f75cd7bf13720738e6a196cc0107ce9a5bd5a0 (diff)
[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls
For the operations get-tx-csum get-sg get-tso get-ufo the default ethtool_op_xxx behavior is fine for all drivers, so we permit op==NULL to imply the default behavior. This provides a more uniform behavior across all drivers, eliminating ethtool(8) "ioctl not supported" errors on older drivers that had not been updated for the latest sub-ioctls. The ethtool_op_xxx() functions are left exported, in case anyone wishes to call them directly from a driver-private implementation -- a not-uncommon case. Should an ethtool_op_xxx() helper remain unused for a while, except by net/core/ethtool.c, we can un-export it at a later date. [ Resolved conflicts with set/get value ethtool patch... -DaveM ] Signed-off-by: Jeff Garzik <jeff@garzik.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tulip')
-rw-r--r--drivers/net/tulip/de2104x.c2
-rw-r--r--drivers/net/tulip/winbond-840.c2
2 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
index bd04e93908ef..ba3d0e5574a4 100644
--- a/drivers/net/tulip/de2104x.c
+++ b/drivers/net/tulip/de2104x.c
@@ -1670,8 +1670,6 @@ static void de_get_regs(struct net_device *dev, struct ethtool_regs *regs,
1670 1670
1671static const struct ethtool_ops de_ethtool_ops = { 1671static const struct ethtool_ops de_ethtool_ops = {
1672 .get_link = ethtool_op_get_link, 1672 .get_link = ethtool_op_get_link,
1673 .get_tx_csum = ethtool_op_get_tx_csum,
1674 .get_sg = ethtool_op_get_sg,
1675 .get_drvinfo = de_get_drvinfo, 1673 .get_drvinfo = de_get_drvinfo,
1676 .get_regs_len = de_get_regs_len, 1674 .get_regs_len = de_get_regs_len,
1677 .get_settings = de_get_settings, 1675 .get_settings = de_get_settings,
diff --git a/drivers/net/tulip/winbond-840.c b/drivers/net/tulip/winbond-840.c
index 396f8455cd32..e00833fadc0b 100644
--- a/drivers/net/tulip/winbond-840.c
+++ b/drivers/net/tulip/winbond-840.c
@@ -1451,8 +1451,6 @@ static const struct ethtool_ops netdev_ethtool_ops = {
1451 .get_link = netdev_get_link, 1451 .get_link = netdev_get_link,
1452 .get_msglevel = netdev_get_msglevel, 1452 .get_msglevel = netdev_get_msglevel,
1453 .set_msglevel = netdev_set_msglevel, 1453 .set_msglevel = netdev_set_msglevel,
1454 .get_sg = ethtool_op_get_sg,
1455 .get_tx_csum = ethtool_op_get_tx_csum,
1456}; 1454};
1457 1455
1458static int netdev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) 1456static int netdev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)