[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 14 insertions, 15 deletions

diff --git a/drivers/net/tulip/winbond-840.c b/drivers/net/tulip/winbond-840.c
index e00833fadc0b..3c40dd6e1a2f 100644
--- a/drivers/net/tulip/winbond-840.c
+++ b/drivers/net/tulip/winbond-840.c
@@ -354,6 +354,7 @@ static int __devinit w840_probe1 (struct pci_dev *pdev,
         int irq;
         int i, option = find_cnt < MAX_UNITS ? options[find_cnt] : 0;
         void __iomem *ioaddr;
+        DECLARE_MAC_BUF(mac);
 
         i = pci_enable_device(pdev);
         if (i) return i;
@@ -433,11 +434,9 @@ static int __devinit w840_probe1 (struct pci_dev *pdev,
         if (i)
                 goto err_out_cleardev;
 
-        printk(KERN_INFO "%s: %s at %p, ",
-                   dev->name, pci_id_tbl[chip_idx].name, ioaddr);
-        for (i = 0; i < 5; i++)
-                        printk("%2.2x:", dev->dev_addr[i]);
-        printk("%2.2x, IRQ %d.\n", dev->dev_addr[i], irq);
+        printk(KERN_INFO "%s: %s at %p, %s, IRQ %d.\n",
+               dev->name, pci_id_tbl[chip_idx].name, ioaddr,
+               print_mac(mac, dev->dev_addr), irq);
 
         if (np->drv_flags & CanHaveMII) {
                 int phy, phy_idx = 0;
@@ -1245,16 +1244,16 @@ static int netdev_rx(struct net_device *dev)
                         }
 #ifndef final_version                           /* Remove after testing. */
                         /* You will want this info for the initial debug. */
-                        if (debug > 5)
-                                printk(KERN_DEBUG "  Rx data %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:"
-                                           "%2.2x %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x %2.2x%2.2x "
-                                           "%d.%d.%d.%d.\n",
-                                           skb->data[0], skb->data[1], skb->data[2], skb->data[3],
-                                           skb->data[4], skb->data[5], skb->data[6], skb->data[7],
-                                           skb->data[8], skb->data[9], skb->data[10],
-                                           skb->data[11], skb->data[12], skb->data[13],
-                                           skb->data[14], skb->data[15], skb->data[16],
-                                           skb->data[17]);
+                        if (debug > 5) {
+                                DECLARE_MAC_BUF(mac);
+                                DECLARE_MAC_BUF(mac2);
+
+                                printk(KERN_DEBUG "  Rx data %s %s"
+                                       " %2.2x%2.2x %d.%d.%d.%d.\n",
+                                       print_mac(mac, &skb->data[0]), print_mac(mac2, &skb->data[6]),
+                                       skb->data[12], skb->data[13],
+                                       skb->data[14], skb->data[15], skb->data[16], skb->data[17]);
+                        }
 #endif
                         skb->protocol = eth_type_trans(skb, dev);
                         netif_rx(skb);