diff options
author | Al Viro <viro@ftp.linux.org.uk> | 2007-12-16 15:53:36 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:07:08 -0500 |
commit | b710b43c306650261c01ad08100791afec78a7db (patch) | |
tree | 656c18e9d3736b84b56c1f91303c28207c424951 /drivers/net/tokenring/olympic.h | |
parent | f5a3ea6f966700ae82504202fdd827f2d3c79e66 (diff) |
endianness annotations and fixes for olympic
* missing braces in !readl(...) & ...
* trivial endianness annotations
* in olympic_arb_cmd() the loop collecting fragments of
packet is b0rken on big-endian - we have
(next_ptr && (buf_ptr=olympic_priv->olympic_lap + ntohs(next_ptr)))
as condition and it should have swab16(), not ntohs() - it's host-endian
byteswapped, not big-endian. So if we get more than one fragment on big-endian
host, we get screwed.
This ntohs() got missed back when the rest of those had been switched
to swab16() in 2.4.0-test2-pre1 - at a guess, nobody had hit fragmented
packets during the testing of PPC fixes.
PS: Ken Aaker cc'd on assumption that he is the same guy who'd done the
original set of PPC fixes in olympic
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net/tokenring/olympic.h')
-rw-r--r-- | drivers/net/tokenring/olympic.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/net/tokenring/olympic.h b/drivers/net/tokenring/olympic.h index 2fc59c997468..c91956310fb2 100644 --- a/drivers/net/tokenring/olympic.h +++ b/drivers/net/tokenring/olympic.h | |||
@@ -216,31 +216,31 @@ | |||
216 | /* xxxx These structures are all little endian in hardware. */ | 216 | /* xxxx These structures are all little endian in hardware. */ |
217 | 217 | ||
218 | struct olympic_tx_desc { | 218 | struct olympic_tx_desc { |
219 | u32 buffer; | 219 | __le32 buffer; |
220 | u32 status_length; | 220 | __le32 status_length; |
221 | }; | 221 | }; |
222 | 222 | ||
223 | struct olympic_tx_status { | 223 | struct olympic_tx_status { |
224 | u32 status; | 224 | __le32 status; |
225 | }; | 225 | }; |
226 | 226 | ||
227 | struct olympic_rx_desc { | 227 | struct olympic_rx_desc { |
228 | u32 buffer; | 228 | __le32 buffer; |
229 | u32 res_length; | 229 | __le32 res_length; |
230 | }; | 230 | }; |
231 | 231 | ||
232 | struct olympic_rx_status { | 232 | struct olympic_rx_status { |
233 | u32 fragmentcnt_framelen; | 233 | __le32 fragmentcnt_framelen; |
234 | u32 status_buffercnt; | 234 | __le32 status_buffercnt; |
235 | }; | 235 | }; |
236 | /* xxxx END These structures are all little endian in hardware. */ | 236 | /* xxxx END These structures are all little endian in hardware. */ |
237 | /* xxxx There may be more, but I'm pretty sure about these */ | 237 | /* xxxx There may be more, but I'm pretty sure about these */ |
238 | 238 | ||
239 | struct mac_receive_buffer { | 239 | struct mac_receive_buffer { |
240 | u16 next ; | 240 | __le16 next ; |
241 | u8 padding ; | 241 | u8 padding ; |
242 | u8 frame_status ; | 242 | u8 frame_status ; |
243 | u16 buffer_length ; | 243 | __le16 buffer_length ; |
244 | u8 frame_data ; | 244 | u8 frame_data ; |
245 | }; | 245 | }; |
246 | 246 | ||