[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 7 insertions, 12 deletions

diff --git a/drivers/net/tokenring/madgemc.c b/drivers/net/tokenring/madgemc.c
index d0ce2ce675d5..5a4151362fc0 100644
--- a/drivers/net/tokenring/madgemc.c
+++ b/drivers/net/tokenring/madgemc.c
@@ -151,7 +151,8 @@ static int __devinit madgemc_probe(struct device *device)
         struct net_local *tp;
         struct card_info *card;
         struct mca_device *mdev = to_mca_device(device);
-        int ret = 0, i = 0;
+        int ret = 0;
+        DECLARE_MAC_BUF(mac);
 
         if (versionprinted++ == 0)
                 printk("%s", version);
@@ -322,11 +323,8 @@ static int __devinit madgemc_probe(struct device *device)
         mca_device_set_name(mdev, (card->cardtype == 0x08)?MADGEMC16_CARDNAME:MADGEMC32_CARDNAME);
         mca_set_adapter_procfn(mdev->slot, madgemc_mcaproc, dev);
 
-        printk("%s:     Ring Station Address: ", dev->name);
-        printk("%2.2x", dev->dev_addr[0]);
-        for (i = 1; i < 6; i++)
-                printk(":%2.2x", dev->dev_addr[i]);
-        printk("\n");
+        printk("%s:     Ring Station Address: %s\n",
+               dev->name, print_mac(mac, dev->dev_addr));
 
         if (tmsdev_init(dev, device)) {
                 printk("%s: unable to get memory for dev->priv.\n", 
@@ -692,11 +690,11 @@ static int madgemc_mcaproc(char *buf, int slot, void *d)
         struct net_local *tp = netdev_priv(dev);
         struct card_info *curcard = tp->tmspriv;
         int len = 0;
+        DECLARE_MAC_BUF(mac);
         
         len += sprintf(buf+len, "-------\n");
         if (curcard) {
                 struct net_local *tp = netdev_priv(dev);
-                int i;
                 
                 len += sprintf(buf+len, "Card Revision: %d\n", curcard->cardrev);
                 len += sprintf(buf+len, "RAM Size: %dkb\n", curcard->ramsize);
@@ -716,11 +714,8 @@ static int madgemc_mcaproc(char *buf, int slot, void *d)
                 }
                 len += sprintf(buf+len, " (%s)\n", (curcard->fairness)?"Unfair":"Fair");
                 
-                len += sprintf(buf+len, "Ring Station Address: ");
-                len += sprintf(buf+len, "%2.2x", dev->dev_addr[0]);
-                for (i = 1; i < 6; i++)
-                        len += sprintf(buf+len, " %2.2x", dev->dev_addr[i]);
-                len += sprintf(buf+len, "\n");
+                len += sprintf(buf+len, "Ring Station Address: %s\n",
+                               print_mac(mac, dev->dev_addr));
         } else 
                 len += sprintf(buf+len, "Card not configured\n");