diff options
| author | David Decotigny <decot@google.com> | 2011-04-27 14:32:40 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-04-29 17:03:01 -0400 |
| commit | 707394972093e2056e1e8cc39be19cf9bcb3e7b3 (patch) | |
| tree | f6dc95219bca6895adf304b79241e9d60561f8f5 /drivers/net/tg3.c | |
| parent | 25db0338813a8915457636b1f6abe6a28fa73f8d (diff) | |
ethtool: cosmetic: Use ethtool ethtool_cmd_speed API
This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.
For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.
All drivers compiled with make allyesconfig ion x86_64 have been
updated.
Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tg3.c')
| -rw-r--r-- | drivers/net/tg3.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 004f266e4352..7c7c9a897c09 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c | |||
| @@ -10025,10 +10025,10 @@ static int tg3_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) | |||
| 10025 | 10025 | ||
| 10026 | cmd->advertising = tp->link_config.advertising; | 10026 | cmd->advertising = tp->link_config.advertising; |
| 10027 | if (netif_running(dev)) { | 10027 | if (netif_running(dev)) { |
| 10028 | cmd->speed = tp->link_config.active_speed; | 10028 | ethtool_cmd_speed_set(cmd, tp->link_config.active_speed); |
| 10029 | cmd->duplex = tp->link_config.active_duplex; | 10029 | cmd->duplex = tp->link_config.active_duplex; |
| 10030 | } else { | 10030 | } else { |
| 10031 | cmd->speed = SPEED_INVALID; | 10031 | ethtool_cmd_speed_set(cmd, SPEED_INVALID); |
| 10032 | cmd->duplex = DUPLEX_INVALID; | 10032 | cmd->duplex = DUPLEX_INVALID; |
| 10033 | } | 10033 | } |
| 10034 | cmd->phy_address = tp->phy_addr; | 10034 | cmd->phy_address = tp->phy_addr; |