diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2009-09-03 06:39:43 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-09-03 23:02:11 -0400 |
commit | 7ab0f2736bfe137a82a7084bbfb5f809da95cabd (patch) | |
tree | e305ec96eceebb285efee4b6fd307822ab257fe6 /drivers/net/tg3.c | |
parent | aae5e7c30fc660c50dfecbdd745799b05af90f01 (diff) |
netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tg3.c')
-rw-r--r-- | drivers/net/tg3.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index bd4981052609..7cf80006eafa 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c | |||
@@ -10610,9 +10610,6 @@ static int tg3_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) | |||
10610 | if (tp->tg3_flags2 & TG3_FLG2_PHY_SERDES) | 10610 | if (tp->tg3_flags2 & TG3_FLG2_PHY_SERDES) |
10611 | break; /* We have no PHY */ | 10611 | break; /* We have no PHY */ |
10612 | 10612 | ||
10613 | if (!capable(CAP_NET_ADMIN)) | ||
10614 | return -EPERM; | ||
10615 | |||
10616 | if (tp->link_config.phy_is_low_power) | 10613 | if (tp->link_config.phy_is_low_power) |
10617 | return -EAGAIN; | 10614 | return -EAGAIN; |
10618 | 10615 | ||