diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2009-05-27 20:00:41 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-05-29 04:46:27 -0400 |
commit | cdd0db058d64f2619b08e7d098ee0014aa0a5bc1 (patch) | |
tree | a5e31f6687eff581309b095781c7e2f0bc676182 /drivers/net/tg3.c | |
parent | 28679751a924c11f7135641f26e99249385de5b4 (diff) |
net: dont update dev->trans_start
Second round of drivers for Gb cards (and NIU one I forgot in the 10GB round)
Now that core network takes care of trans_start updates, dont do it
in drivers themselves, if possible. Drivers can avoid one cache miss
(on dev->trans_start) in their start_xmit() handler.
Exceptions are NETIF_F_LLTX drivers
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tg3.c')
-rw-r--r-- | drivers/net/tg3.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index eb65e25989f3..a39b534fb43e 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c | |||
@@ -5194,9 +5194,7 @@ static int tg3_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
5194 | } | 5194 | } |
5195 | 5195 | ||
5196 | out_unlock: | 5196 | out_unlock: |
5197 | mmiowb(); | 5197 | mmiowb(); |
5198 | |||
5199 | dev->trans_start = jiffies; | ||
5200 | 5198 | ||
5201 | return NETDEV_TX_OK; | 5199 | return NETDEV_TX_OK; |
5202 | } | 5200 | } |
@@ -5407,9 +5405,7 @@ static int tg3_start_xmit_dma_bug(struct sk_buff *skb, struct net_device *dev) | |||
5407 | } | 5405 | } |
5408 | 5406 | ||
5409 | out_unlock: | 5407 | out_unlock: |
5410 | mmiowb(); | 5408 | mmiowb(); |
5411 | |||
5412 | dev->trans_start = jiffies; | ||
5413 | 5409 | ||
5414 | return NETDEV_TX_OK; | 5410 | return NETDEV_TX_OK; |
5415 | } | 5411 | } |