diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-09-02 16:07:41 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-09-02 22:06:22 -0400 |
commit | bc8acf2c8c3e43fcc192762a9f964b3e9a17748b (patch) | |
tree | e3a91392771a22390e59c24fcb7bad3045ce17d1 /drivers/net/tehuti.c | |
parent | 7162f6691e9d39d8d866574687cddb3f1ec65d72 (diff) |
drivers/net: avoid some skb->ip_summed initializations
fresh skbs have ip_summed set to CHECKSUM_NONE (0)
We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.
Introduce skb_checksum_none_assert() helper so that we keep this
assertion documented in driver sources.
Change most occurrences of :
skb->ip_summed = CHECKSUM_NONE;
by :
skb_checksum_none_assert(skb);
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tehuti.c')
-rw-r--r-- | drivers/net/tehuti.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c index 3128d6a8e9ce..8b3dc1eb4015 100644 --- a/drivers/net/tehuti.c +++ b/drivers/net/tehuti.c | |||
@@ -1297,12 +1297,13 @@ static int bdx_rx_receive(struct bdx_priv *priv, struct rxd_fifo *f, int budget) | |||
1297 | ndev->stats.rx_bytes += len; | 1297 | ndev->stats.rx_bytes += len; |
1298 | 1298 | ||
1299 | skb_put(skb, len); | 1299 | skb_put(skb, len); |
1300 | skb->ip_summed = CHECKSUM_UNNECESSARY; | ||
1301 | skb->protocol = eth_type_trans(skb, ndev); | 1300 | skb->protocol = eth_type_trans(skb, ndev); |
1302 | 1301 | ||
1303 | /* Non-IP packets aren't checksum-offloaded */ | 1302 | /* Non-IP packets aren't checksum-offloaded */ |
1304 | if (GET_RXD_PKT_ID(rxd_val1) == 0) | 1303 | if (GET_RXD_PKT_ID(rxd_val1) == 0) |
1305 | skb->ip_summed = CHECKSUM_NONE; | 1304 | skb_checksum_none_assert(skb); |
1305 | else | ||
1306 | skb->ip_summed = CHECKSUM_UNNECESSARY; | ||
1306 | 1307 | ||
1307 | NETIF_RX_MUX(priv, rxd_val1, rxd_vlan, skb); | 1308 | NETIF_RX_MUX(priv, rxd_val1, rxd_vlan, skb); |
1308 | 1309 | ||