PCI: Change all drivers to use pci_device->revision

Instead of all drivers reading pci config space to get the revision
ID, they can now use the pci_device->revision member.

This exposes some issues where drivers where reading a word or a dword
for the revision number, and adding useless error-handling around the
read. Some drivers even just read it for no purpose of all.

In devices where the revision ID is being copied over and used in what
appears to be the equivalent of hotpath, I have left the copy code
and the cached copy as not to influence the driver's performance.

Compile tested with make all{yes,mod}config on x86_64 and i386.

Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Acked-by: Dave Jones <davej@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 2 insertions, 5 deletions

diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c
index e1f912d04043..c9f7b7aa5556 100644
--- a/drivers/net/sundance.c
+++ b/drivers/net/sundance.c
@@ -397,7 +397,6 @@ struct netdev_private {
         unsigned char phys[MII_CNT];            /* MII device addresses, only first one used. */
         struct pci_dev *pci_dev;
         void __iomem *base;
-        unsigned char pci_rev_id;
 };
 
 /* The station address location in the EEPROM. */
@@ -544,8 +543,6 @@ static int __devinit sundance_probe1 (struct pci_dev *pdev,
         dev->change_mtu = &change_mtu;
         pci_set_drvdata(pdev, dev);
 
-        pci_read_config_byte(pdev, PCI_REVISION_ID, &np->pci_rev_id);
-
         i = register_netdev(dev);
         if (i)
                 goto err_out_unmap_rx;
@@ -828,7 +825,7 @@ static int netdev_open(struct net_device *dev)
         iowrite8(100, ioaddr + RxDMAPollPeriod);
         iowrite8(127, ioaddr + TxDMAPollPeriod);
         /* Fix DFE-580TX packet drop issue */
-        if (np->pci_rev_id >= 0x14)
+        if (np->pci_dev->revision >= 0x14)
                 iowrite8(0x01, ioaddr + DebugCtrl1);
         netif_start_queue(dev);
 
@@ -1194,7 +1191,7 @@ static irqreturn_t intr_handler(int irq, void *dev_instance)
                         hw_frame_id = ioread8(ioaddr + TxFrameId);
                 }
 
-                if (np->pci_rev_id >= 0x14) {
+                if (np->pci_dev->revision >= 0x14) {
                         spin_lock(&np->lock);
                         for (; np->cur_tx - np->dirty_tx > 0; np->dirty_tx++) {
                                 int entry = np->dirty_tx % TX_RING_SIZE;