diff options
author | Wang Chen <wangchen@cn.fujitsu.com> | 2008-11-13 02:38:36 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-11-13 02:38:36 -0500 |
commit | 8f15ea42b64941001a401cf855a0869e24f3a845 (patch) | |
tree | 27c7534ad70ebda6986491daeac0ebe0f1ca54ed /drivers/net/sun3_82586.c | |
parent | 4cf1653aa90c6320dc8032443b5e322820aa28b1 (diff) |
netdevice: safe convert to netdev_priv() #part-3
We have some reasons to kill netdev->priv:
1. netdev->priv is equal to netdev_priv().
2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
netdev_priv() is more flexible than netdev->priv.
But we cann't kill netdev->priv, because so many drivers reference to it
directly.
This patch is a safe convert for netdev->priv to netdev_priv(netdev).
Since all of the netdev->priv is only for read.
But it is too big to be sent in one mail.
I split it to 4 parts and make every part smaller than 100,000 bytes,
which is max size allowed by vger.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sun3_82586.c')
-rw-r--r-- | drivers/net/sun3_82586.c | 38 |
1 files changed, 21 insertions, 17 deletions
diff --git a/drivers/net/sun3_82586.c b/drivers/net/sun3_82586.c index e531302d95f5..e8f97d5c9c23 100644 --- a/drivers/net/sun3_82586.c +++ b/drivers/net/sun3_82586.c | |||
@@ -247,7 +247,7 @@ static int check586(struct net_device *dev,char *where,unsigned size) | |||
247 | */ | 247 | */ |
248 | static void alloc586(struct net_device *dev) | 248 | static void alloc586(struct net_device *dev) |
249 | { | 249 | { |
250 | struct priv *p = (struct priv *) dev->priv; | 250 | struct priv *p = netdev_priv(dev); |
251 | 251 | ||
252 | sun3_reset586(); | 252 | sun3_reset586(); |
253 | DELAY(1); | 253 | DELAY(1); |
@@ -363,17 +363,21 @@ static int __init sun3_82586_probe1(struct net_device *dev,int ioaddr) | |||
363 | goto out; | 363 | goto out; |
364 | } | 364 | } |
365 | 365 | ||
366 | ((struct priv *) (dev->priv))->memtop = (char *)dvma_btov(dev->mem_start); | 366 | ((struct priv *)netdev_priv(dev))->memtop = |
367 | ((struct priv *) (dev->priv))->base = (unsigned long) dvma_btov(0); | 367 | (char *)dvma_btov(dev->mem_start); |
368 | ((struct priv *)netdev_priv(dev))->base = (unsigned long) dvma_btov(0); | ||
368 | alloc586(dev); | 369 | alloc586(dev); |
369 | 370 | ||
370 | /* set number of receive-buffs according to memsize */ | 371 | /* set number of receive-buffs according to memsize */ |
371 | if(size == 0x2000) | 372 | if(size == 0x2000) |
372 | ((struct priv *) dev->priv)->num_recv_buffs = NUM_RECV_BUFFS_8; | 373 | ((struct priv *)netdev_priv(dev))->num_recv_buffs = |
374 | NUM_RECV_BUFFS_8; | ||
373 | else if(size == 0x4000) | 375 | else if(size == 0x4000) |
374 | ((struct priv *) dev->priv)->num_recv_buffs = NUM_RECV_BUFFS_16; | 376 | ((struct priv *)netdev_priv(dev))->num_recv_buffs = |
377 | NUM_RECV_BUFFS_16; | ||
375 | else | 378 | else |
376 | ((struct priv *) dev->priv)->num_recv_buffs = NUM_RECV_BUFFS_32; | 379 | ((struct priv *)netdev_priv(dev))->num_recv_buffs = |
380 | NUM_RECV_BUFFS_32; | ||
377 | 381 | ||
378 | printk("Memaddr: 0x%lx, Memsize: %d, IRQ %d\n",dev->mem_start,size, dev->irq); | 382 | printk("Memaddr: 0x%lx, Memsize: %d, IRQ %d\n",dev->mem_start,size, dev->irq); |
379 | 383 | ||
@@ -397,7 +401,7 @@ static int init586(struct net_device *dev) | |||
397 | { | 401 | { |
398 | void *ptr; | 402 | void *ptr; |
399 | int i,result=0; | 403 | int i,result=0; |
400 | struct priv *p = (struct priv *) dev->priv; | 404 | struct priv *p = netdev_priv(dev); |
401 | volatile struct configure_cmd_struct *cfg_cmd; | 405 | volatile struct configure_cmd_struct *cfg_cmd; |
402 | volatile struct iasetup_cmd_struct *ias_cmd; | 406 | volatile struct iasetup_cmd_struct *ias_cmd; |
403 | volatile struct tdr_cmd_struct *tdr_cmd; | 407 | volatile struct tdr_cmd_struct *tdr_cmd; |
@@ -631,7 +635,7 @@ static void *alloc_rfa(struct net_device *dev,void *ptr) | |||
631 | volatile struct rfd_struct *rfd = (struct rfd_struct *)ptr; | 635 | volatile struct rfd_struct *rfd = (struct rfd_struct *)ptr; |
632 | volatile struct rbd_struct *rbd; | 636 | volatile struct rbd_struct *rbd; |
633 | int i; | 637 | int i; |
634 | struct priv *p = (struct priv *) dev->priv; | 638 | struct priv *p = netdev_priv(dev); |
635 | 639 | ||
636 | memset((char *) rfd,0,sizeof(struct rfd_struct)*(p->num_recv_buffs+rfdadd)); | 640 | memset((char *) rfd,0,sizeof(struct rfd_struct)*(p->num_recv_buffs+rfdadd)); |
637 | p->rfd_first = rfd; | 641 | p->rfd_first = rfd; |
@@ -683,7 +687,7 @@ static irqreturn_t sun3_82586_interrupt(int irq,void *dev_id) | |||
683 | printk ("sun3_82586-interrupt: irq %d for unknown device.\n",irq); | 687 | printk ("sun3_82586-interrupt: irq %d for unknown device.\n",irq); |
684 | return IRQ_NONE; | 688 | return IRQ_NONE; |
685 | } | 689 | } |
686 | p = (struct priv *) dev->priv; | 690 | p = netdev_priv(dev); |
687 | 691 | ||
688 | if(debuglevel > 1) | 692 | if(debuglevel > 1) |
689 | printk("I"); | 693 | printk("I"); |
@@ -753,7 +757,7 @@ static void sun3_82586_rcv_int(struct net_device *dev) | |||
753 | unsigned short totlen; | 757 | unsigned short totlen; |
754 | struct sk_buff *skb; | 758 | struct sk_buff *skb; |
755 | struct rbd_struct *rbd; | 759 | struct rbd_struct *rbd; |
756 | struct priv *p = (struct priv *) dev->priv; | 760 | struct priv *p = netdev_priv(dev); |
757 | 761 | ||
758 | if(debuglevel > 0) | 762 | if(debuglevel > 0) |
759 | printk("R"); | 763 | printk("R"); |
@@ -871,7 +875,7 @@ static void sun3_82586_rcv_int(struct net_device *dev) | |||
871 | 875 | ||
872 | static void sun3_82586_rnr_int(struct net_device *dev) | 876 | static void sun3_82586_rnr_int(struct net_device *dev) |
873 | { | 877 | { |
874 | struct priv *p = (struct priv *) dev->priv; | 878 | struct priv *p = netdev_priv(dev); |
875 | 879 | ||
876 | p->stats.rx_errors++; | 880 | p->stats.rx_errors++; |
877 | 881 | ||
@@ -895,7 +899,7 @@ static void sun3_82586_rnr_int(struct net_device *dev) | |||
895 | static void sun3_82586_xmt_int(struct net_device *dev) | 899 | static void sun3_82586_xmt_int(struct net_device *dev) |
896 | { | 900 | { |
897 | int status; | 901 | int status; |
898 | struct priv *p = (struct priv *) dev->priv; | 902 | struct priv *p = netdev_priv(dev); |
899 | 903 | ||
900 | if(debuglevel > 0) | 904 | if(debuglevel > 0) |
901 | printk("X"); | 905 | printk("X"); |
@@ -945,7 +949,7 @@ static void sun3_82586_xmt_int(struct net_device *dev) | |||
945 | 949 | ||
946 | static void startrecv586(struct net_device *dev) | 950 | static void startrecv586(struct net_device *dev) |
947 | { | 951 | { |
948 | struct priv *p = (struct priv *) dev->priv; | 952 | struct priv *p = netdev_priv(dev); |
949 | 953 | ||
950 | WAIT_4_SCB_CMD(); | 954 | WAIT_4_SCB_CMD(); |
951 | WAIT_4_SCB_CMD_RUC(); | 955 | WAIT_4_SCB_CMD_RUC(); |
@@ -957,7 +961,7 @@ static void startrecv586(struct net_device *dev) | |||
957 | 961 | ||
958 | static void sun3_82586_timeout(struct net_device *dev) | 962 | static void sun3_82586_timeout(struct net_device *dev) |
959 | { | 963 | { |
960 | struct priv *p = (struct priv *) dev->priv; | 964 | struct priv *p = netdev_priv(dev); |
961 | #ifndef NO_NOPCOMMANDS | 965 | #ifndef NO_NOPCOMMANDS |
962 | if(p->scb->cus & CU_ACTIVE) /* COMMAND-UNIT active? */ | 966 | if(p->scb->cus & CU_ACTIVE) /* COMMAND-UNIT active? */ |
963 | { | 967 | { |
@@ -999,7 +1003,7 @@ static int sun3_82586_send_packet(struct sk_buff *skb, struct net_device *dev) | |||
999 | #ifndef NO_NOPCOMMANDS | 1003 | #ifndef NO_NOPCOMMANDS |
1000 | int next_nop; | 1004 | int next_nop; |
1001 | #endif | 1005 | #endif |
1002 | struct priv *p = (struct priv *) dev->priv; | 1006 | struct priv *p = netdev_priv(dev); |
1003 | 1007 | ||
1004 | if(skb->len > XMIT_BUFF_SIZE) | 1008 | if(skb->len > XMIT_BUFF_SIZE) |
1005 | { | 1009 | { |
@@ -1108,7 +1112,7 @@ static int sun3_82586_send_packet(struct sk_buff *skb, struct net_device *dev) | |||
1108 | 1112 | ||
1109 | static struct net_device_stats *sun3_82586_get_stats(struct net_device *dev) | 1113 | static struct net_device_stats *sun3_82586_get_stats(struct net_device *dev) |
1110 | { | 1114 | { |
1111 | struct priv *p = (struct priv *) dev->priv; | 1115 | struct priv *p = netdev_priv(dev); |
1112 | unsigned short crc,aln,rsc,ovrn; | 1116 | unsigned short crc,aln,rsc,ovrn; |
1113 | 1117 | ||
1114 | crc = swab16(p->scb->crc_errs); /* get error-statistic from the ni82586 */ | 1118 | crc = swab16(p->scb->crc_errs); /* get error-statistic from the ni82586 */ |
@@ -1171,7 +1175,7 @@ void cleanup_module(void) | |||
1171 | */ | 1175 | */ |
1172 | void sun3_82586_dump(struct net_device *dev,void *ptr) | 1176 | void sun3_82586_dump(struct net_device *dev,void *ptr) |
1173 | { | 1177 | { |
1174 | struct priv *p = (struct priv *) dev->priv; | 1178 | struct priv *p = netdev_priv(dev); |
1175 | struct dump_cmd_struct *dump_cmd = (struct dump_cmd_struct *) ptr; | 1179 | struct dump_cmd_struct *dump_cmd = (struct dump_cmd_struct *) ptr; |
1176 | int i; | 1180 | int i; |
1177 | 1181 | ||