diff options
author | Dan Carpenter <error27@gmail.com> | 2010-07-21 21:16:48 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-07-22 17:14:48 -0400 |
commit | 1ff219068c0e032a6fd64c45bd69f3bc7374feb6 (patch) | |
tree | 9978774f6e4f5b1fbcc2e6dd9e178e31f4c1a9e4 /drivers/net/stmmac/stmmac_main.c | |
parent | b77026b391f4f43ca148cf6c55a93f7487ff6ed8 (diff) |
stmmac: handle allocation errors in setup functions
If the allocations fail in either dwmac1000_setup() or dwmac100_setup()
then return NULL. These are called from stmmac_mac_device_setup(). The
check for NULL returns in stmmac_mac_device_setup() needed to be moved
forward a couple lines.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/stmmac/stmmac_main.c')
-rw-r--r-- | drivers/net/stmmac/stmmac_main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/stmmac/stmmac_main.c b/drivers/net/stmmac/stmmac_main.c index acf061686940..0bdd3326c94a 100644 --- a/drivers/net/stmmac/stmmac_main.c +++ b/drivers/net/stmmac/stmmac_main.c | |||
@@ -1558,15 +1558,15 @@ static int stmmac_mac_device_setup(struct net_device *dev) | |||
1558 | else | 1558 | else |
1559 | device = dwmac100_setup(ioaddr); | 1559 | device = dwmac100_setup(ioaddr); |
1560 | 1560 | ||
1561 | if (!device) | ||
1562 | return -ENOMEM; | ||
1563 | |||
1561 | if (priv->enh_desc) { | 1564 | if (priv->enh_desc) { |
1562 | device->desc = &enh_desc_ops; | 1565 | device->desc = &enh_desc_ops; |
1563 | pr_info("\tEnhanced descriptor structure\n"); | 1566 | pr_info("\tEnhanced descriptor structure\n"); |
1564 | } else | 1567 | } else |
1565 | device->desc = &ndesc_ops; | 1568 | device->desc = &ndesc_ops; |
1566 | 1569 | ||
1567 | if (!device) | ||
1568 | return -ENOMEM; | ||
1569 | |||
1570 | priv->hw = device; | 1570 | priv->hw = device; |
1571 | 1571 | ||
1572 | priv->wolenabled = priv->hw->pmt; /* PMT supported */ | 1572 | priv->wolenabled = priv->hw->pmt; /* PMT supported */ |