diff options
author | David Decotigny <decot@google.com> | 2011-04-27 14:32:40 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-04-29 17:03:01 -0400 |
commit | 707394972093e2056e1e8cc39be19cf9bcb3e7b3 (patch) | |
tree | f6dc95219bca6895adf304b79241e9d60561f8f5 /drivers/net/smc911x.c | |
parent | 25db0338813a8915457636b1f6abe6a28fa73f8d (diff) |
ethtool: cosmetic: Use ethtool ethtool_cmd_speed API
This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.
For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.
All drivers compiled with make allyesconfig ion x86_64 have been
updated.
Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/smc911x.c')
-rw-r--r-- | drivers/net/smc911x.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 66831f378396..053863aefb12 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c | |||
@@ -1488,9 +1488,9 @@ smc911x_ethtool_getsettings(struct net_device *dev, struct ethtool_cmd *cmd) | |||
1488 | SUPPORTED_TP | SUPPORTED_AUI; | 1488 | SUPPORTED_TP | SUPPORTED_AUI; |
1489 | 1489 | ||
1490 | if (lp->ctl_rspeed == 10) | 1490 | if (lp->ctl_rspeed == 10) |
1491 | cmd->speed = SPEED_10; | 1491 | ethtool_cmd_speed_set(cmd, SPEED_10); |
1492 | else if (lp->ctl_rspeed == 100) | 1492 | else if (lp->ctl_rspeed == 100) |
1493 | cmd->speed = SPEED_100; | 1493 | ethtool_cmd_speed_set(cmd, SPEED_100); |
1494 | 1494 | ||
1495 | cmd->autoneg = AUTONEG_DISABLE; | 1495 | cmd->autoneg = AUTONEG_DISABLE; |
1496 | if (lp->mii.phy_id==1) | 1496 | if (lp->mii.phy_id==1) |