aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/sky2.c
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2007-09-15 17:41:06 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-10-10 19:51:17 -0400
commit88d3aafdae5c5e1d2dd9489a5c8a24e29d335f2e (patch)
tree272ce75c30a170420ac8bbfd679c3faed9f9d20a /drivers/net/sky2.c
parent09f75cd7bf13720738e6a196cc0107ce9a5bd5a0 (diff)
[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls
For the operations get-tx-csum get-sg get-tso get-ufo the default ethtool_op_xxx behavior is fine for all drivers, so we permit op==NULL to imply the default behavior. This provides a more uniform behavior across all drivers, eliminating ethtool(8) "ioctl not supported" errors on older drivers that had not been updated for the latest sub-ioctls. The ethtool_op_xxx() functions are left exported, in case anyone wishes to call them directly from a driver-private implementation -- a not-uncommon case. Should an ethtool_op_xxx() helper remain unused for a while, except by net/core/ethtool.c, we can un-export it at a later date. [ Resolved conflicts with set/get value ethtool patch... -DaveM ] Signed-off-by: Jeff Garzik <jeff@garzik.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sky2.c')
-rw-r--r--drivers/net/sky2.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 1b9e5f40ddee..b8c15f881eba 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -3710,11 +3710,8 @@ static const struct ethtool_ops sky2_ethtool_ops = {
3710 .get_eeprom_len = sky2_get_eeprom_len, 3710 .get_eeprom_len = sky2_get_eeprom_len,
3711 .get_eeprom = sky2_get_eeprom, 3711 .get_eeprom = sky2_get_eeprom,
3712 .set_eeprom = sky2_set_eeprom, 3712 .set_eeprom = sky2_set_eeprom,
3713 .get_sg = ethtool_op_get_sg,
3714 .set_sg = ethtool_op_set_sg, 3713 .set_sg = ethtool_op_set_sg,
3715 .get_tx_csum = ethtool_op_get_tx_csum,
3716 .set_tx_csum = sky2_set_tx_csum, 3714 .set_tx_csum = sky2_set_tx_csum,
3717 .get_tso = ethtool_op_get_tso,
3718 .set_tso = sky2_set_tso, 3715 .set_tso = sky2_set_tso,
3719 .get_rx_csum = sky2_get_rx_csum, 3716 .get_rx_csum = sky2_get_rx_csum,
3720 .set_rx_csum = sky2_set_rx_csum, 3717 .set_rx_csum = sky2_set_rx_csum,