diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2009-09-03 06:39:43 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-09-03 23:02:11 -0400 |
commit | 7ab0f2736bfe137a82a7084bbfb5f809da95cabd (patch) | |
tree | e305ec96eceebb285efee4b6fd307822ab257fe6 /drivers/net/skge.c | |
parent | aae5e7c30fc660c50dfecbdd745799b05af90f01 (diff) |
netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/skge.c')
-rw-r--r-- | drivers/net/skge.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/skge.c b/drivers/net/skge.c index 1a1e68549f5c..62e852e21ab2 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c | |||
@@ -2496,9 +2496,6 @@ static int skge_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) | |||
2496 | } | 2496 | } |
2497 | 2497 | ||
2498 | case SIOCSMIIREG: | 2498 | case SIOCSMIIREG: |
2499 | if (!capable(CAP_NET_ADMIN)) | ||
2500 | return -EPERM; | ||
2501 | |||
2502 | spin_lock_bh(&hw->phy_lock); | 2499 | spin_lock_bh(&hw->phy_lock); |
2503 | if (hw->chip_id == CHIP_ID_GENESIS) | 2500 | if (hw->chip_id == CHIP_ID_GENESIS) |
2504 | err = xm_phy_write(hw, skge->port, data->reg_num & 0x1f, | 2501 | err = xm_phy_write(hw, skge->port, data->reg_num & 0x1f, |