diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2009-09-03 06:39:43 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-09-03 23:02:11 -0400 |
commit | 7ab0f2736bfe137a82a7084bbfb5f809da95cabd (patch) | |
tree | e305ec96eceebb285efee4b6fd307822ab257fe6 /drivers/net/sis900.c | |
parent | aae5e7c30fc660c50dfecbdd745799b05af90f01 (diff) |
netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sis900.c')
-rw-r--r-- | drivers/net/sis900.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c index d8827323507a..97949d0a699b 100644 --- a/drivers/net/sis900.c +++ b/drivers/net/sis900.c | |||
@@ -2128,8 +2128,6 @@ static int mii_ioctl(struct net_device *net_dev, struct ifreq *rq, int cmd) | |||
2128 | return 0; | 2128 | return 0; |
2129 | 2129 | ||
2130 | case SIOCSMIIREG: /* Write MII PHY register. */ | 2130 | case SIOCSMIIREG: /* Write MII PHY register. */ |
2131 | if (!capable(CAP_NET_ADMIN)) | ||
2132 | return -EPERM; | ||
2133 | mdio_write(net_dev, data->phy_id & 0x1f, data->reg_num & 0x1f, data->val_in); | 2131 | mdio_write(net_dev, data->phy_id & 0x1f, data->reg_num & 0x1f, data->val_in); |
2134 | return 0; | 2132 | return 0; |
2135 | default: | 2133 | default: |