diff options
author | Steve Hodgson <shodgson@solarflare.com> | 2010-04-28 05:28:27 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-04-28 15:44:35 -0400 |
commit | 41b7e4c3268d9d2056b9c94cceb386649f7b185b (patch) | |
tree | 706d46fdd10943ba86d4eda2ff210bc506997144 /drivers/net/sfc/workarounds.h | |
parent | b7b40eeb0f76e73503a7e5a98d1353c2e42d9a18 (diff) |
sfc: Extend the legacy interrupt workarounds
Siena has two problems with legacy interrupts:
1. There is no synchronisation between the ISR read completion,
and the interrupt deassert message.
2. A downstream read at the "wrong" moment can return 0, and
suppress generating the next interrupt.
Falcon should suffer from both of these, and it appears it does.
Enable EFX_WORKAROUND_15783 on Falcon as well.
Also, when we see queues == 0, ensure we always schedule or rearm
every event queue.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sfc/workarounds.h')
-rw-r--r-- | drivers/net/sfc/workarounds.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/sfc/workarounds.h b/drivers/net/sfc/workarounds.h index acd9c734e483..518f7fc91473 100644 --- a/drivers/net/sfc/workarounds.h +++ b/drivers/net/sfc/workarounds.h | |||
@@ -37,7 +37,7 @@ | |||
37 | /* Truncated IPv4 packets can confuse the TX packet parser */ | 37 | /* Truncated IPv4 packets can confuse the TX packet parser */ |
38 | #define EFX_WORKAROUND_15592 EFX_WORKAROUND_FALCON_AB | 38 | #define EFX_WORKAROUND_15592 EFX_WORKAROUND_FALCON_AB |
39 | /* Legacy ISR read can return zero once */ | 39 | /* Legacy ISR read can return zero once */ |
40 | #define EFX_WORKAROUND_15783 EFX_WORKAROUND_SIENA | 40 | #define EFX_WORKAROUND_15783 EFX_WORKAROUND_ALWAYS |
41 | /* Legacy interrupt storm when interrupt fifo fills */ | 41 | /* Legacy interrupt storm when interrupt fifo fills */ |
42 | #define EFX_WORKAROUND_17213 EFX_WORKAROUND_SIENA | 42 | #define EFX_WORKAROUND_17213 EFX_WORKAROUND_SIENA |
43 | 43 | ||