diff options
author | Stephen Hemminger <shemminger@vyatta.com> | 2009-08-31 15:50:58 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-09-01 04:14:07 -0400 |
commit | 61357325f377889a1daffa14962d705dc814dd0e (patch) | |
tree | 7b436f1097abbc5681de6d1e5901f62963b42220 /drivers/net/sfc/tx.c | |
parent | d0cf9c0dadcdc89a755bcb301cfc9c796eb28ccf (diff) |
netdev: convert bulk of drivers to netdev_tx_t
In a couple of cases collapse some extra code like:
int retval = NETDEV_TX_OK;
...
return retval;
into
return NETDEV_TX_OK;
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sfc/tx.c')
-rw-r--r-- | drivers/net/sfc/tx.c | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/drivers/net/sfc/tx.c b/drivers/net/sfc/tx.c index 14a14788566c..489c4de31447 100644 --- a/drivers/net/sfc/tx.c +++ b/drivers/net/sfc/tx.c | |||
@@ -138,8 +138,8 @@ static void efx_tsoh_free(struct efx_tx_queue *tx_queue, | |||
138 | * Returns NETDEV_TX_OK or NETDEV_TX_BUSY | 138 | * Returns NETDEV_TX_OK or NETDEV_TX_BUSY |
139 | * You must hold netif_tx_lock() to call this function. | 139 | * You must hold netif_tx_lock() to call this function. |
140 | */ | 140 | */ |
141 | static int efx_enqueue_skb(struct efx_tx_queue *tx_queue, | 141 | static netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, |
142 | struct sk_buff *skb) | 142 | struct sk_buff *skb) |
143 | { | 143 | { |
144 | struct efx_nic *efx = tx_queue->efx; | 144 | struct efx_nic *efx = tx_queue->efx; |
145 | struct pci_dev *pci_dev = efx->pci_dev; | 145 | struct pci_dev *pci_dev = efx->pci_dev; |
@@ -152,7 +152,7 @@ static int efx_enqueue_skb(struct efx_tx_queue *tx_queue, | |||
152 | unsigned int dma_len; | 152 | unsigned int dma_len; |
153 | bool unmap_single; | 153 | bool unmap_single; |
154 | int q_space, i = 0; | 154 | int q_space, i = 0; |
155 | int rc = NETDEV_TX_OK; | 155 | netdev_tx_t rc = NETDEV_TX_OK; |
156 | 156 | ||
157 | EFX_BUG_ON_PARANOID(tx_queue->write_count != tx_queue->insert_count); | 157 | EFX_BUG_ON_PARANOID(tx_queue->write_count != tx_queue->insert_count); |
158 | 158 | ||
@@ -353,14 +353,11 @@ static void efx_dequeue_buffers(struct efx_tx_queue *tx_queue, | |||
353 | * | 353 | * |
354 | * Context: netif_tx_lock held | 354 | * Context: netif_tx_lock held |
355 | */ | 355 | */ |
356 | inline int efx_xmit(struct efx_nic *efx, | 356 | inline netdev_tx_t efx_xmit(struct efx_nic *efx, |
357 | struct efx_tx_queue *tx_queue, struct sk_buff *skb) | 357 | struct efx_tx_queue *tx_queue, struct sk_buff *skb) |
358 | { | 358 | { |
359 | int rc; | ||
360 | |||
361 | /* Map fragments for DMA and add to TX queue */ | 359 | /* Map fragments for DMA and add to TX queue */ |
362 | rc = efx_enqueue_skb(tx_queue, skb); | 360 | return efx_enqueue_skb(tx_queue, skb); |
363 | return rc; | ||
364 | } | 361 | } |
365 | 362 | ||
366 | /* Initiate a packet transmission. We use one channel per CPU | 363 | /* Initiate a packet transmission. We use one channel per CPU |
@@ -372,7 +369,8 @@ inline int efx_xmit(struct efx_nic *efx, | |||
372 | * Note that returning anything other than NETDEV_TX_OK will cause the | 369 | * Note that returning anything other than NETDEV_TX_OK will cause the |
373 | * OS to free the skb. | 370 | * OS to free the skb. |
374 | */ | 371 | */ |
375 | int efx_hard_start_xmit(struct sk_buff *skb, struct net_device *net_dev) | 372 | netdev_tx_t efx_hard_start_xmit(struct sk_buff *skb, |
373 | struct net_device *net_dev) | ||
376 | { | 374 | { |
377 | struct efx_nic *efx = netdev_priv(net_dev); | 375 | struct efx_nic *efx = netdev_priv(net_dev); |
378 | struct efx_tx_queue *tx_queue; | 376 | struct efx_tx_queue *tx_queue; |