sfc: Split MAC stats DMA initiation and completion

From: Steve Hodgson <shodgson@solarflare.com>

Currently we initiate MAC stats DMA and busy-wait for completion when
stats are requested.  We can improve on this with a periodic timer to
initiate and poll for stats, and opportunistically poll when stats are
requested.

Since efx_nic::stats_disable_count and efx_stats_{disable,enable}()
are Falcon-specific, rename them and move them accordingly.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 0 insertions, 5 deletions

diff --git a/drivers/net/sfc/falcon_gmac.c b/drivers/net/sfc/falcon_gmac.c
index 967f3fb397c9..2aeb3fc02786 100644
--- a/drivers/net/sfc/falcon_gmac.c
+++ b/drivers/net/sfc/falcon_gmac.c
@@ -130,11 +130,6 @@ static void falcon_update_stats_gmac(struct efx_nic *efx)
         struct efx_mac_stats *mac_stats = &efx->mac_stats;
         unsigned long old_rx_pause, old_tx_pause;
         unsigned long new_rx_pause, new_tx_pause;
-        int rc;
-
-        rc = falcon_dma_stats(efx, GDmaDone_offset);
-        if (rc)
-                return;
 
         /* Pause frames are erroneously counted as errors (SFC bug 3269) */
         old_rx_pause = mac_stats->rx_pause;