diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2008-09-01 07:49:08 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-09-03 09:53:49 -0400 |
commit | 3c78708fe83d0fff994683e396e28ef259b7497b (patch) | |
tree | d4f446406f548a6c08b56a2b72d7288d2cf48fa2 /drivers/net/sfc/efx.c | |
parent | 8c8661e4cefdd1ddbfe7d5120f046694555d9e5c (diff) |
sfc: Remove the STATE_RESETTING flag
This was originally a kludge to fix broken locking, which has since
been fixed properly.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net/sfc/efx.c')
-rw-r--r-- | drivers/net/sfc/efx.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c index e1e2f8060563..d5930863691c 100644 --- a/drivers/net/sfc/efx.c +++ b/drivers/net/sfc/efx.c | |||
@@ -140,8 +140,7 @@ static void efx_fini_channels(struct efx_nic *efx); | |||
140 | 140 | ||
141 | #define EFX_ASSERT_RESET_SERIALISED(efx) \ | 141 | #define EFX_ASSERT_RESET_SERIALISED(efx) \ |
142 | do { \ | 142 | do { \ |
143 | if ((efx->state == STATE_RUNNING) || \ | 143 | if (efx->state == STATE_RUNNING) \ |
144 | (efx->state == STATE_RESETTING)) \ | ||
145 | ASSERT_RTNL(); \ | 144 | ASSERT_RTNL(); \ |
146 | } while (0) | 145 | } while (0) |
147 | 146 | ||
@@ -1615,7 +1614,6 @@ static int efx_reset(struct efx_nic *efx) | |||
1615 | goto unlock_rtnl; | 1614 | goto unlock_rtnl; |
1616 | } | 1615 | } |
1617 | 1616 | ||
1618 | efx->state = STATE_RESETTING; | ||
1619 | EFX_INFO(efx, "resetting (%d)\n", method); | 1617 | EFX_INFO(efx, "resetting (%d)\n", method); |
1620 | 1618 | ||
1621 | efx_reset_down(efx, &ecmd); | 1619 | efx_reset_down(efx, &ecmd); |
@@ -1646,7 +1644,6 @@ static int efx_reset(struct efx_nic *efx) | |||
1646 | goto disable; | 1644 | goto disable; |
1647 | 1645 | ||
1648 | EFX_LOG(efx, "reset complete\n"); | 1646 | EFX_LOG(efx, "reset complete\n"); |
1649 | efx->state = STATE_RUNNING; | ||
1650 | unlock_rtnl: | 1647 | unlock_rtnl: |
1651 | rtnl_unlock(); | 1648 | rtnl_unlock(); |
1652 | return 0; | 1649 | return 0; |