diff options
author | David Decotigny <decot@google.com> | 2011-04-27 14:32:40 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-04-29 17:03:01 -0400 |
commit | 707394972093e2056e1e8cc39be19cf9bcb3e7b3 (patch) | |
tree | f6dc95219bca6895adf304b79241e9d60561f8f5 /drivers/net/sc92031.c | |
parent | 25db0338813a8915457636b1f6abe6a28fa73f8d (diff) |
ethtool: cosmetic: Use ethtool ethtool_cmd_speed API
This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.
For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.
All drivers compiled with make allyesconfig ion x86_64 have been
updated.
Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sc92031.c')
-rw-r--r-- | drivers/net/sc92031.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c index f3ffc1df3b2d..fa74314ef789 100644 --- a/drivers/net/sc92031.c +++ b/drivers/net/sc92031.c | |||
@@ -1173,7 +1173,8 @@ static int sc92031_ethtool_get_settings(struct net_device *dev, | |||
1173 | if (phy_ctrl & PhyCtrlAne) | 1173 | if (phy_ctrl & PhyCtrlAne) |
1174 | cmd->advertising |= ADVERTISED_Autoneg; | 1174 | cmd->advertising |= ADVERTISED_Autoneg; |
1175 | 1175 | ||
1176 | cmd->speed = (output_status & 0x2) ? SPEED_100 : SPEED_10; | 1176 | ethtool_cmd_speed_set(cmd, |
1177 | (output_status & 0x2) ? SPEED_100 : SPEED_10); | ||
1177 | cmd->duplex = (output_status & 0x4) ? DUPLEX_FULL : DUPLEX_HALF; | 1178 | cmd->duplex = (output_status & 0x4) ? DUPLEX_FULL : DUPLEX_HALF; |
1178 | cmd->port = PORT_MII; | 1179 | cmd->port = PORT_MII; |
1179 | cmd->phy_address = phy_address; | 1180 | cmd->phy_address = phy_address; |