aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/sc92031.c
diff options
context:
space:
mode:
authorDavid Decotigny <decot@google.com>2011-04-27 14:32:39 -0400
committerDavid S. Miller <davem@davemloft.net>2011-04-29 17:03:00 -0400
commit25db0338813a8915457636b1f6abe6a28fa73f8d (patch)
tree29ea39e45de1342beb4e3c58da0cfbc9915b617e /drivers/net/sc92031.c
parent8ae6daca85c8bbd6a32c382db5e2a2a989f8bed2 (diff)
ethtool: Use full 32 bit speed range in ethtool's set_settings
This makes sure the ethtool's set_settings() callback of network drivers don't ignore the 16 most significant bits when ethtool calls their set_settings(). All drivers compiled with make allyesconfig on x86_64 have been updated. Signed-off-by: David Decotigny <decot@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sc92031.c')
-rw-r--r--drivers/net/sc92031.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c
index 76290a8c3c14..f3ffc1df3b2d 100644
--- a/drivers/net/sc92031.c
+++ b/drivers/net/sc92031.c
@@ -1188,10 +1188,11 @@ static int sc92031_ethtool_set_settings(struct net_device *dev,
1188{ 1188{
1189 struct sc92031_priv *priv = netdev_priv(dev); 1189 struct sc92031_priv *priv = netdev_priv(dev);
1190 void __iomem *port_base = priv->port_base; 1190 void __iomem *port_base = priv->port_base;
1191 u32 speed = ethtool_cmd_speed(cmd);
1191 u32 phy_ctrl; 1192 u32 phy_ctrl;
1192 u32 old_phy_ctrl; 1193 u32 old_phy_ctrl;
1193 1194
1194 if (!(cmd->speed == SPEED_10 || cmd->speed == SPEED_100)) 1195 if (!(speed == SPEED_10 || speed == SPEED_100))
1195 return -EINVAL; 1196 return -EINVAL;
1196 if (!(cmd->duplex == DUPLEX_HALF || cmd->duplex == DUPLEX_FULL)) 1197 if (!(cmd->duplex == DUPLEX_HALF || cmd->duplex == DUPLEX_FULL))
1197 return -EINVAL; 1198 return -EINVAL;
@@ -1229,7 +1230,7 @@ static int sc92031_ethtool_set_settings(struct net_device *dev,
1229 // FIXME: Whole branch guessed 1230 // FIXME: Whole branch guessed
1230 phy_ctrl = 0; 1231 phy_ctrl = 0;
1231 1232
1232 if (cmd->speed == SPEED_10) 1233 if (speed == SPEED_10)
1233 phy_ctrl |= PhyCtrlSpd10; 1234 phy_ctrl |= PhyCtrlSpd10;
1234 else /* cmd->speed == SPEED_100 */ 1235 else /* cmd->speed == SPEED_100 */
1235 phy_ctrl |= PhyCtrlSpd100; 1236 phy_ctrl |= PhyCtrlSpd100;