diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-09-15 17:41:06 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:51:17 -0400 |
commit | 88d3aafdae5c5e1d2dd9489a5c8a24e29d335f2e (patch) | |
tree | 272ce75c30a170420ac8bbfd679c3faed9f9d20a /drivers/net/sc92031.c | |
parent | 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0 (diff) |
[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls
For the operations
get-tx-csum
get-sg
get-tso
get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.
This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.
The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case. Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.
[ Resolved conflicts with set/get value ethtool patch... -DaveM ]
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sc92031.c')
-rw-r--r-- | drivers/net/sc92031.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c index 872cb1cc9c41..02c472ecbe55 100644 --- a/drivers/net/sc92031.c +++ b/drivers/net/sc92031.c | |||
@@ -1396,13 +1396,9 @@ static struct ethtool_ops sc92031_ethtool_ops = { | |||
1396 | .set_wol = sc92031_ethtool_set_wol, | 1396 | .set_wol = sc92031_ethtool_set_wol, |
1397 | .nway_reset = sc92031_ethtool_nway_reset, | 1397 | .nway_reset = sc92031_ethtool_nway_reset, |
1398 | .get_link = ethtool_op_get_link, | 1398 | .get_link = ethtool_op_get_link, |
1399 | .get_tx_csum = ethtool_op_get_tx_csum, | ||
1400 | .get_sg = ethtool_op_get_sg, | ||
1401 | .get_tso = ethtool_op_get_tso, | ||
1402 | .get_strings = sc92031_ethtool_get_strings, | 1399 | .get_strings = sc92031_ethtool_get_strings, |
1403 | .get_stats_count = sc92031_ethtool_get_stats_count, | 1400 | .get_stats_count = sc92031_ethtool_get_stats_count, |
1404 | .get_ethtool_stats = sc92031_ethtool_get_ethtool_stats, | 1401 | .get_ethtool_stats = sc92031_ethtool_get_ethtool_stats, |
1405 | .get_ufo = ethtool_op_get_ufo, | ||
1406 | }; | 1402 | }; |
1407 | 1403 | ||
1408 | static int __devinit sc92031_probe(struct pci_dev *pdev, | 1404 | static int __devinit sc92031_probe(struct pci_dev *pdev, |