qlcnic: fail when try to setup unsupported features

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 10 insertions, 3 deletions

diff --git a/drivers/net/qlcnic/qlcnic_ethtool.c b/drivers/net/qlcnic/qlcnic_ethtool.c
index d4e803e2a977..b9d5acbaf540 100644
--- a/drivers/net/qlcnic/qlcnic_ethtool.c
+++ b/drivers/net/qlcnic/qlcnic_ethtool.c
@@ -983,12 +983,19 @@ static int qlcnic_set_flags(struct net_device *netdev, u32 data)
         struct qlcnic_adapter *adapter = netdev_priv(netdev);
         int hw_lro;
 
+        if (data & ~ETH_FLAG_LRO)
+                return -EOPNOTSUPP;
+
         if (!(adapter->capabilities & QLCNIC_FW_CAPABILITY_HW_LRO))
                 return -EINVAL;
 
-        ethtool_op_set_flags(netdev, data);
-
-        hw_lro = (data & ETH_FLAG_LRO) ? QLCNIC_LRO_ENABLED : 0;
+        if (data & ETH_FLAG_LRO) {
+                hw_lro = QLCNIC_LRO_ENABLED;
+                netdev->features |= NETIF_F_LRO;
+        } else {
+                hw_lro = 0;
+                netdev->features &= ~NETIF_F_LRO;
+        }
 
         if (qlcnic_config_hw_lro(adapter, hw_lro))
                 return -EIO;