[PPP]: Remove ptr comparisons to 0

fix sparse warnings "Using plain integer as NULL pointer"

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 14 insertions, 13 deletions

diff --git a/drivers/net/ppp_synctty.c b/drivers/net/ppp_synctty.c
index 00e2fb48b4ae..f0c6a1926a02 100644
--- a/drivers/net/ppp_synctty.c
+++ b/drivers/net/ppp_synctty.c
@@ -209,7 +209,7 @@ ppp_sync_open(struct tty_struct *tty)
 
         ap = kzalloc(sizeof(*ap), GFP_KERNEL);
         err = -ENOMEM;
-        if (ap == 0)
+        if (!ap)
                 goto out;
 
         /* initialize the syncppp structure */
@@ -262,7 +262,7 @@ ppp_sync_close(struct tty_struct *tty)
         ap = tty->disc_data;
         tty->disc_data = NULL;
         write_unlock_irq(&disc_data_lock);
-        if (ap == 0)
+        if (!ap)
                 return;
 
         /*
@@ -278,7 +278,7 @@ ppp_sync_close(struct tty_struct *tty)
 
         ppp_unregister_channel(&ap->chan);
         skb_queue_purge(&ap->rqueue);
-        if (ap->tpkt != 0)
+        if (ap->tpkt)
                 kfree_skb(ap->tpkt);
         kfree(ap);
 }
@@ -325,13 +325,13 @@ ppp_synctty_ioctl(struct tty_struct *tty, struct file *file,
         int __user *p = (int __user *)arg;
         int err, val;
 
-        if (ap == 0)
+        if (!ap)
                 return -ENXIO;
         err = -EFAULT;
         switch (cmd) {
         case PPPIOCGCHAN:
                 err = -ENXIO;
-                if (ap == 0)
+                if (!ap)
                         break;
                 err = -EFAULT;
                 if (put_user(ppp_channel_index(&ap->chan), p))
@@ -341,7 +341,7 @@ ppp_synctty_ioctl(struct tty_struct *tty, struct file *file,
 
         case PPPIOCGUNIT:
                 err = -ENXIO;
-                if (ap == 0)
+                if (!ap)
                         break;
                 err = -EFAULT;
                 if (put_user(ppp_unit_number(&ap->chan), p))
@@ -390,7 +390,7 @@ ppp_sync_receive(struct tty_struct *tty, const unsigned char *buf,
         struct syncppp *ap = sp_get(tty);
         unsigned long flags;
 
-        if (ap == 0)
+        if (!ap)
                 return;
         spin_lock_irqsave(&ap->recv_lock, flags);
         ppp_sync_input(ap, buf, cflags, count);
@@ -409,7 +409,7 @@ ppp_sync_wakeup(struct tty_struct *tty)
         struct syncppp *ap = sp_get(tty);
 
         clear_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);
-        if (ap == 0)
+        if (!ap)
                 return;
         set_bit(XMIT_WAKEUP, &ap->xmit_flags);
         tasklet_schedule(&ap->tsk);
@@ -651,7 +651,7 @@ ppp_sync_push(struct syncppp *ap)
         for (;;) {
                 if (test_and_clear_bit(XMIT_WAKEUP, &ap->xmit_flags))
                         tty_stuffed = 0;
-                if (!tty_stuffed && ap->tpkt != 0) {
+                if (!tty_stuffed && ap->tpkt) {
                         set_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);
                         sent = tty->driver->write(tty, ap->tpkt->data, ap->tpkt->len);
                         if (sent < 0)
@@ -669,7 +669,7 @@ ppp_sync_push(struct syncppp *ap)
                 /* haven't made any progress */
                 spin_unlock_bh(&ap->xmit_lock);
                 if (!(test_bit(XMIT_WAKEUP, &ap->xmit_flags)
-                      || (!tty_stuffed && ap->tpkt != 0)))
+                      || (!tty_stuffed && ap->tpkt)))
                         break;
                 if (!spin_trylock_bh(&ap->xmit_lock))
                         break;
@@ -677,7 +677,7 @@ ppp_sync_push(struct syncppp *ap)
         return done;
 
 flush:
-        if (ap->tpkt != 0) {
+        if (ap->tpkt) {
                 kfree_skb(ap->tpkt);
                 ap->tpkt = NULL;
                 clear_bit(XMIT_FULL, &ap->xmit_flags);
@@ -732,7 +732,8 @@ ppp_sync_input(struct syncppp *ap, const unsigned char *buf,
                 ppp_print_buffer ("receive buffer", buf, count);
 
         /* stuff the chars in the skb */
-        if ((skb = dev_alloc_skb(ap->mru + PPP_HDRLEN + 2)) == 0) {
+        skb = dev_alloc_skb(ap->mru + PPP_HDRLEN + 2);
+        if (!skb) {
                 printk(KERN_ERR "PPPsync: no memory (input pkt)\n");
                 goto err;
         }
@@ -740,7 +741,7 @@ ppp_sync_input(struct syncppp *ap, const unsigned char *buf,
         if (buf[0] != PPP_ALLSTATIONS)
                 skb_reserve(skb, 2 + (buf[0] & 1));
 
-        if (flags != 0 && *flags) {
+        if (flags && *flags) {
                 /* error flag set, ignore frame */
                 goto err;
         } else if (count > skb_tailroom(skb)) {