diff options
author | Patrick McHardy <kaber@trash.net> | 2009-06-12 02:22:29 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-06-13 04:18:50 -0400 |
commit | 5b548140225c6bbbbd560551dd1048b2c0ce58be (patch) | |
tree | 9306a37dbca0095ca6d88e0b0ab297bcb2dc5ae8 /drivers/net/plip.c | |
parent | 5b2c4b972c0226406361f83b747eb5cdab51e68e (diff) |
net: use symbolic values for ndo_start_xmit() return codes
Convert magic values 1 and -1 to NETDEV_TX_BUSY and NETDEV_TX_LOCKED respectively.
0 (NETDEV_TX_OK) is not changed to keep the noise down, except in very few cases
where its in direct proximity to one of the other values.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/plip.c')
-rw-r--r-- | drivers/net/plip.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/plip.c b/drivers/net/plip.c index 0be0f0b164f3..7a62f781fef2 100644 --- a/drivers/net/plip.c +++ b/drivers/net/plip.c | |||
@@ -955,12 +955,12 @@ plip_tx_packet(struct sk_buff *skb, struct net_device *dev) | |||
955 | struct plip_local *snd = &nl->snd_data; | 955 | struct plip_local *snd = &nl->snd_data; |
956 | 956 | ||
957 | if (netif_queue_stopped(dev)) | 957 | if (netif_queue_stopped(dev)) |
958 | return 1; | 958 | return NETDEV_TX_BUSY; |
959 | 959 | ||
960 | /* We may need to grab the bus */ | 960 | /* We may need to grab the bus */ |
961 | if (!nl->port_owner) { | 961 | if (!nl->port_owner) { |
962 | if (parport_claim(nl->pardev)) | 962 | if (parport_claim(nl->pardev)) |
963 | return 1; | 963 | return NETDEV_TX_BUSY; |
964 | nl->port_owner = 1; | 964 | nl->port_owner = 1; |
965 | } | 965 | } |
966 | 966 | ||
@@ -969,7 +969,7 @@ plip_tx_packet(struct sk_buff *skb, struct net_device *dev) | |||
969 | if (skb->len > dev->mtu + dev->hard_header_len) { | 969 | if (skb->len > dev->mtu + dev->hard_header_len) { |
970 | printk(KERN_WARNING "%s: packet too big, %d.\n", dev->name, (int)skb->len); | 970 | printk(KERN_WARNING "%s: packet too big, %d.\n", dev->name, (int)skb->len); |
971 | netif_start_queue (dev); | 971 | netif_start_queue (dev); |
972 | return 1; | 972 | return NETDEV_TX_BUSY; |
973 | } | 973 | } |
974 | 974 | ||
975 | if (net_debug > 2) | 975 | if (net_debug > 2) |