diff options
| author | Jiri Slaby <jirislaby@gmail.com> | 2009-07-13 07:23:39 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-07-14 15:03:39 -0400 |
| commit | bc23283c7bc90958927abe26eedc562701743a88 (patch) | |
| tree | 9bf032d073db84d3b094d2c43fd0cb352095ce45 /drivers/net/phy | |
| parent | ee686ca919193d7c1f87f907e732df5e2f942523 (diff) | |
NET: phy_device, fix lock imbalance
Don't forget to unlock a mutex in phy_scan_fixups on a fail path.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy')
| -rw-r--r-- | drivers/net/phy/phy_device.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index eba937c46376..b10fedd82143 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c | |||
| @@ -134,8 +134,10 @@ int phy_scan_fixups(struct phy_device *phydev) | |||
| 134 | 134 | ||
| 135 | err = fixup->run(phydev); | 135 | err = fixup->run(phydev); |
| 136 | 136 | ||
| 137 | if (err < 0) | 137 | if (err < 0) { |
| 138 | mutex_unlock(&phy_fixup_lock); | ||
| 138 | return err; | 139 | return err; |
| 140 | } | ||
| 139 | } | 141 | } |
| 140 | } | 142 | } |
| 141 | mutex_unlock(&phy_fixup_lock); | 143 | mutex_unlock(&phy_fixup_lock); |
