aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/phy/phy_device.c
diff options
context:
space:
mode:
authorKrzysztof Halasa <khc@pm.waw.pl>2008-12-25 19:50:41 -0500
committerDavid S. Miller <davem@davemloft.net>2008-12-25 19:50:41 -0500
commit161c8d2f50109b44b664eaf23831ea1587979a61 (patch)
tree1d9b2b4aaa72296f98c449e6f955ade61e84ed02 /drivers/net/phy/phy_device.c
parentf7d1b9f5aafa371d7f51f644aa3c38bc914e9205 (diff)
net: PHYLIB mdio fixes #2
The PHYLIB mdio code has more problems in error paths: - mdiobus_release can be called before bus->state is set to MDIOBUS_REGISTERED - mdiobus_scan allocates resources which need to be freed - the comment is wrong, the resistors used are actually pull-ups. Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phy_device.c')
-rw-r--r--drivers/net/phy/phy_device.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index f84f6a1b530c..e35460165bf7 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -232,7 +232,7 @@ struct phy_device * get_phy_device(struct mii_bus *bus, int addr)
232 return NULL; 232 return NULL;
233 233
234 /* 234 /*
235 * Broken hardware is sometimes missing the pull down resistor on the 235 * Broken hardware is sometimes missing the pull-up resistor on the
236 * MDIO line, which results in reads to non-existent devices returning 236 * MDIO line, which results in reads to non-existent devices returning
237 * 0 rather than 0xffff. Catch this here and treat 0 as a non-existent 237 * 0 rather than 0xffff. Catch this here and treat 0 as a non-existent
238 * device as well. 238 * device as well.