diff options
author | Jeff Garzik <jeff@garzik.org> | 2006-10-01 07:27:46 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2006-10-01 07:27:46 -0400 |
commit | b7a00ecd557859c4037b6465fdd6c9a49b1fa649 (patch) | |
tree | c3981f739ee2286ecb36054db52b24e690509060 /drivers/net/phy/fixed.c | |
parent | 1c7da74c4aab595a994beb5fe728ebf0d0b41f59 (diff) |
[netdrvr] phy: Fix bugs in error handling
The recent __must_check stuff flagged some error handling bugs.
phy/fixed.c:
* handle device_bind_driver() failure
phy/phy_device.c:
* handle device_bind_driver() failure
* release rwsem upon failure
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net/phy/fixed.c')
-rw-r--r-- | drivers/net/phy/fixed.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c index 19f7ee63276f..94b47c8d0ab4 100644 --- a/drivers/net/phy/fixed.c +++ b/drivers/net/phy/fixed.c | |||
@@ -289,9 +289,13 @@ static int fixed_mdio_register_device(int number, int speed, int duplex) | |||
289 | goto probe_fail; | 289 | goto probe_fail; |
290 | } | 290 | } |
291 | 291 | ||
292 | device_bind_driver(&phydev->dev); | 292 | err = device_bind_driver(&phydev->dev); |
293 | |||
293 | up_write(&phydev->dev.bus->subsys.rwsem); | 294 | up_write(&phydev->dev.bus->subsys.rwsem); |
294 | 295 | ||
296 | if (err) | ||
297 | goto probe_fail; | ||
298 | |||
295 | return 0; | 299 | return 0; |
296 | 300 | ||
297 | probe_fail: | 301 | probe_fail: |