ethtool: Call ethtool's get/set_settings callbacks with cleaned data

This makes sure that when a driver calls the ethtool's
get/set_settings() callback of another driver, the data passed to it
is clean. This guarantees that speed_hi will be zeroed correctly if
the called callback doesn't explicitely set it: we are sure we don't
get a corrupted speed from the underlying driver. We also take care of
setting the cmd field appropriately (ETHTOOL_GSET/SSET).

This applies to dev_ethtool_get_settings(), which now makes sure it
sets up that ethtool command parameter correctly before passing it to
drivers. This also means that whoever calls dev_ethtool_get_settings()
does not have to clean the ethtool command parameter. This function
also becomes an exported symbol instead of an inline.

All drivers visible to make allyesconfig under x86_64 have been
updated.

Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 8 insertions, 8 deletions

diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c
index 0a1efbae1bc0..b48aba9e4227 100644
--- a/drivers/net/pcnet32.c
+++ b/drivers/net/pcnet32.c
@@ -2099,7 +2099,7 @@ static int pcnet32_open(struct net_device *dev)
                 int first_phy = -1;
                 u16 bmcr;
                 u32 bcr9;
-                struct ethtool_cmd ecmd;
+                struct ethtool_cmd ecmd = { .cmd = ETHTOOL_GSET };
 
                 /*
                  * There is really no good other way to handle multiple PHYs
@@ -2115,9 +2115,9 @@ static int pcnet32_open(struct net_device *dev)
                         ecmd.port = PORT_MII;
                         ecmd.transceiver = XCVR_INTERNAL;
                         ecmd.autoneg = AUTONEG_DISABLE;
-                        ecmd.speed =
-                            lp->
-                            options & PCNET32_PORT_100 ? SPEED_100 : SPEED_10;
+                        ethtool_cmd_speed_set(&ecmd,
+                                              (lp->options & PCNET32_PORT_100) ?
+                                              SPEED_100 : SPEED_10);
                         bcr9 = lp->a.read_bcr(ioaddr, 9);
 
                         if (lp->options & PCNET32_PORT_FD) {
@@ -2763,11 +2763,11 @@ static void pcnet32_check_media(struct net_device *dev, int verbose)
                 netif_carrier_on(dev);
                 if (lp->mii) {
                         if (netif_msg_link(lp)) {
-                                struct ethtool_cmd ecmd;
+                                struct ethtool_cmd ecmd = {
+                                        .cmd = ETHTOOL_GSET };
                                 mii_ethtool_gset(&lp->mii_if, &ecmd);
-                                netdev_info(dev, "link up, %sMbps, %s-duplex\n",
-                                            (ecmd.speed == SPEED_100)
-                                            ? "100" : "10",
+                                netdev_info(dev, "link up, %uMbps, %s-duplex\n",
+                                            ethtool_cmd_speed(&ecmd),
                                             (ecmd.duplex == DUPLEX_FULL)
                                             ? "full" : "half");
                         }