diff options
author | Patrick McHardy <kaber@trash.net> | 2009-06-12 02:22:29 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-06-13 04:18:50 -0400 |
commit | 5b548140225c6bbbbd560551dd1048b2c0ce58be (patch) | |
tree | 9306a37dbca0095ca6d88e0b0ab297bcb2dc5ae8 /drivers/net/pcmcia | |
parent | 5b2c4b972c0226406361f83b747eb5cdab51e68e (diff) |
net: use symbolic values for ndo_start_xmit() return codes
Convert magic values 1 and -1 to NETDEV_TX_BUSY and NETDEV_TX_LOCKED respectively.
0 (NETDEV_TX_OK) is not changed to keep the noise down, except in very few cases
where its in direct proximity to one of the other values.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/pcmcia')
-rw-r--r-- | drivers/net/pcmcia/axnet_cs.c | 2 | ||||
-rw-r--r-- | drivers/net/pcmcia/fmvj18x_cs.c | 2 | ||||
-rw-r--r-- | drivers/net/pcmcia/smc91c92_cs.c | 2 | ||||
-rw-r--r-- | drivers/net/pcmcia/xirc2ps_cs.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/pcmcia/axnet_cs.c b/drivers/net/pcmcia/axnet_cs.c index 15b8fe61695b..0e38d80fd255 100644 --- a/drivers/net/pcmcia/axnet_cs.c +++ b/drivers/net/pcmcia/axnet_cs.c | |||
@@ -1130,7 +1130,7 @@ static int axnet_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
1130 | outb_p(ENISR_ALL, e8390_base + EN0_IMR); | 1130 | outb_p(ENISR_ALL, e8390_base + EN0_IMR); |
1131 | spin_unlock_irqrestore(&ei_local->page_lock, flags); | 1131 | spin_unlock_irqrestore(&ei_local->page_lock, flags); |
1132 | dev->stats.tx_errors++; | 1132 | dev->stats.tx_errors++; |
1133 | return 1; | 1133 | return NETDEV_TX_BUSY; |
1134 | } | 1134 | } |
1135 | 1135 | ||
1136 | /* | 1136 | /* |
diff --git a/drivers/net/pcmcia/fmvj18x_cs.c b/drivers/net/pcmcia/fmvj18x_cs.c index 81e6660a433a..479d5b494371 100644 --- a/drivers/net/pcmcia/fmvj18x_cs.c +++ b/drivers/net/pcmcia/fmvj18x_cs.c | |||
@@ -877,7 +877,7 @@ static int fjn_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
877 | if (length > ETH_FRAME_LEN) { | 877 | if (length > ETH_FRAME_LEN) { |
878 | printk(KERN_NOTICE "%s: Attempting to send a large packet" | 878 | printk(KERN_NOTICE "%s: Attempting to send a large packet" |
879 | " (%d bytes).\n", dev->name, length); | 879 | " (%d bytes).\n", dev->name, length); |
880 | return 1; | 880 | return NETDEV_TX_BUSY; |
881 | } | 881 | } |
882 | 882 | ||
883 | DEBUG(4, "%s: Transmitting a packet of length %lu.\n", | 883 | DEBUG(4, "%s: Transmitting a packet of length %lu.\n", |
diff --git a/drivers/net/pcmcia/smc91c92_cs.c b/drivers/net/pcmcia/smc91c92_cs.c index 48dbb35747d8..37e05d3ab893 100644 --- a/drivers/net/pcmcia/smc91c92_cs.c +++ b/drivers/net/pcmcia/smc91c92_cs.c | |||
@@ -1388,7 +1388,7 @@ static int smc_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
1388 | dev->stats.tx_aborted_errors++; | 1388 | dev->stats.tx_aborted_errors++; |
1389 | printk(KERN_DEBUG "%s: Internal error -- sent packet while busy.\n", | 1389 | printk(KERN_DEBUG "%s: Internal error -- sent packet while busy.\n", |
1390 | dev->name); | 1390 | dev->name); |
1391 | return 1; | 1391 | return NETDEV_TX_BUSY; |
1392 | } | 1392 | } |
1393 | smc->saved_skb = skb; | 1393 | smc->saved_skb = skb; |
1394 | 1394 | ||
diff --git a/drivers/net/pcmcia/xirc2ps_cs.c b/drivers/net/pcmcia/xirc2ps_cs.c index a3685c0d22fc..ef37d22c7e1d 100644 --- a/drivers/net/pcmcia/xirc2ps_cs.c +++ b/drivers/net/pcmcia/xirc2ps_cs.c | |||
@@ -1399,7 +1399,7 @@ do_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
1399 | DEBUG(2 + (okay ? 2 : 0), "%s: avail. tx space=%u%s\n", | 1399 | DEBUG(2 + (okay ? 2 : 0), "%s: avail. tx space=%u%s\n", |
1400 | dev->name, freespace, okay ? " (okay)":" (not enough)"); | 1400 | dev->name, freespace, okay ? " (okay)":" (not enough)"); |
1401 | if (!okay) { /* not enough space */ | 1401 | if (!okay) { /* not enough space */ |
1402 | return 1; /* upper layer may decide to requeue this packet */ | 1402 | return NETDEV_TX_BUSY; /* upper layer may decide to requeue this packet */ |
1403 | } | 1403 | } |
1404 | /* send the packet */ | 1404 | /* send the packet */ |
1405 | PutWord(XIRCREG_EDP, (u_short)pktlen); | 1405 | PutWord(XIRCREG_EDP, (u_short)pktlen); |