diff options
author | Jaswinder Singh Rajput <jaswinder@kernel.org> | 2009-09-12 05:08:49 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-09-22 16:59:59 -0400 |
commit | 03b88a66c040acb4b770221ca24a609527b47fc5 (patch) | |
tree | 0cae69a39246db005e048960d74c1e273434d20a /drivers/net/pcmcia | |
parent | 44c852ead55b7450c8cff0dc90a3d48310300210 (diff) |
pcmcia: pcnet_cs.c removing useless condition
'if (i < NR_INFO)' will only true if we breaks from 'for (i = 0; i < NR_INFO; i++)'
So removing useless 'if (i < NR_INFO)'
This also fixed following compilation warning :
CC [M] drivers/net/pcmcia/pcnet_cs.o
drivers/net/pcmcia/pcnet_cs.c: In function ‘get_hwinfo’:
drivers/net/pcmcia/pcnet_cs.c:321: warning: ‘base’ may be used uninitialized in this function
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/pcmcia')
-rw-r--r-- | drivers/net/pcmcia/pcnet_cs.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/net/pcmcia/pcnet_cs.c b/drivers/net/pcmcia/pcnet_cs.c index 97db1c732342..474876c879cb 100644 --- a/drivers/net/pcmcia/pcnet_cs.c +++ b/drivers/net/pcmcia/pcnet_cs.c | |||
@@ -340,12 +340,11 @@ static hw_info_t *get_hwinfo(struct pcmcia_device *link) | |||
340 | base = &virt[hw_info[i].offset & (req.Size-1)]; | 340 | base = &virt[hw_info[i].offset & (req.Size-1)]; |
341 | if ((readb(base+0) == hw_info[i].a0) && | 341 | if ((readb(base+0) == hw_info[i].a0) && |
342 | (readb(base+2) == hw_info[i].a1) && | 342 | (readb(base+2) == hw_info[i].a1) && |
343 | (readb(base+4) == hw_info[i].a2)) | 343 | (readb(base+4) == hw_info[i].a2)) { |
344 | break; | 344 | for (j = 0; j < 6; j++) |
345 | } | 345 | dev->dev_addr[j] = readb(base + (j<<1)); |
346 | if (i < NR_INFO) { | 346 | break; |
347 | for (j = 0; j < 6; j++) | 347 | } |
348 | dev->dev_addr[j] = readb(base + (j<<1)); | ||
349 | } | 348 | } |
350 | 349 | ||
351 | iounmap(virt); | 350 | iounmap(virt); |