diff options
author | Joe Perches <joe@perches.com> | 2010-08-12 08:22:51 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-08-18 17:26:30 -0400 |
commit | 636b8116d4e116eca1ac978f546b16fadfc15a6c (patch) | |
tree | 287364907b68208a473472e9f6314b64ced16d3d /drivers/net/pcmcia/com20020_cs.c | |
parent | 00093fab980d0a8950a64bdf9e346d0497b9a7e4 (diff) |
drivers/net/pcmcia: Use pr_<level> and netdev_<level>
On Mon, 2010-08-09 at 17:34 +0200, Dominik Brodowski wrote:
> look good from a PCMCIA point of view, therefore:
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
If PCMCIA is still being looked after, then here's
another for you, maybe for 2.6.37.
Use the more descriptive logging message styles.
There are whitespace/indentation errors in the original
sources that these changes do not modify, so checkpatch
errors were cheerfully ignored.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/pcmcia/com20020_cs.c')
-rw-r--r-- | drivers/net/pcmcia/com20020_cs.c | 32 |
1 files changed, 14 insertions, 18 deletions
diff --git a/drivers/net/pcmcia/com20020_cs.c b/drivers/net/pcmcia/com20020_cs.c index 3c400cfa82ae..f065c35cd4b7 100644 --- a/drivers/net/pcmcia/com20020_cs.c +++ b/drivers/net/pcmcia/com20020_cs.c | |||
@@ -52,23 +52,23 @@ | |||
52 | 52 | ||
53 | #define VERSION "arcnet: COM20020 PCMCIA support loaded.\n" | 53 | #define VERSION "arcnet: COM20020 PCMCIA support loaded.\n" |
54 | 54 | ||
55 | #ifdef DEBUG | ||
56 | 55 | ||
57 | static void regdump(struct net_device *dev) | 56 | static void regdump(struct net_device *dev) |
58 | { | 57 | { |
58 | #ifdef DEBUG | ||
59 | int ioaddr = dev->base_addr; | 59 | int ioaddr = dev->base_addr; |
60 | int count; | 60 | int count; |
61 | 61 | ||
62 | printk("com20020 register dump:\n"); | 62 | netdev_dbg(dev, "register dump:\n"); |
63 | for (count = ioaddr; count < ioaddr + 16; count++) | 63 | for (count = ioaddr; count < ioaddr + 16; count++) |
64 | { | 64 | { |
65 | if (!(count % 16)) | 65 | if (!(count % 16)) |
66 | printk("\n%04X: ", count); | 66 | pr_cont("%04X:", count); |
67 | printk("%02X ", inb(count)); | 67 | pr_cont(" %02X", inb(count)); |
68 | } | 68 | } |
69 | printk("\n"); | 69 | pr_cont("\n"); |
70 | 70 | ||
71 | printk("buffer0 dump:\n"); | 71 | netdev_dbg(dev, "buffer0 dump:\n"); |
72 | /* set up the address register */ | 72 | /* set up the address register */ |
73 | count = 0; | 73 | count = 0; |
74 | outb((count >> 8) | RDDATAflag | AUTOINCflag, _ADDR_HI); | 74 | outb((count >> 8) | RDDATAflag | AUTOINCflag, _ADDR_HI); |
@@ -77,19 +77,15 @@ static void regdump(struct net_device *dev) | |||
77 | for (count = 0; count < 256+32; count++) | 77 | for (count = 0; count < 256+32; count++) |
78 | { | 78 | { |
79 | if (!(count % 16)) | 79 | if (!(count % 16)) |
80 | printk("\n%04X: ", count); | 80 | pr_cont("%04X:", count); |
81 | 81 | ||
82 | /* copy the data */ | 82 | /* copy the data */ |
83 | printk("%02X ", inb(_MEMDATA)); | 83 | pr_cont(" %02X", inb(_MEMDATA)); |
84 | } | 84 | } |
85 | printk("\n"); | 85 | pr_cont("\n"); |
86 | #endif | ||
86 | } | 87 | } |
87 | 88 | ||
88 | #else | ||
89 | |||
90 | static inline void regdump(struct net_device *dev) { } | ||
91 | |||
92 | #endif | ||
93 | 89 | ||
94 | 90 | ||
95 | /*====================================================================*/ | 91 | /*====================================================================*/ |
@@ -301,13 +297,13 @@ static int com20020_config(struct pcmcia_device *link) | |||
301 | i = com20020_found(dev, 0); /* calls register_netdev */ | 297 | i = com20020_found(dev, 0); /* calls register_netdev */ |
302 | 298 | ||
303 | if (i != 0) { | 299 | if (i != 0) { |
304 | dev_printk(KERN_NOTICE, &link->dev, | 300 | dev_notice(&link->dev, |
305 | "com20020_cs: com20020_found() failed\n"); | 301 | "com20020_found() failed\n"); |
306 | goto failed; | 302 | goto failed; |
307 | } | 303 | } |
308 | 304 | ||
309 | dev_dbg(&link->dev,KERN_INFO "%s: port %#3lx, irq %d\n", | 305 | netdev_dbg(dev, "port %#3lx, irq %d\n", |
310 | dev->name, dev->base_addr, dev->irq); | 306 | dev->base_addr, dev->irq); |
311 | return 0; | 307 | return 0; |
312 | 308 | ||
313 | failed: | 309 | failed: |