ethtool: Call ethtool's get/set_settings callbacks with cleaned data

This makes sure that when a driver calls the ethtool's
get/set_settings() callback of another driver, the data passed to it
is clean. This guarantees that speed_hi will be zeroed correctly if
the called callback doesn't explicitely set it: we are sure we don't
get a corrupted speed from the underlying driver. We also take care of
setting the cmd field appropriately (ETHTOOL_GSET/SSET).

This applies to dev_ethtool_get_settings(), which now makes sure it
sets up that ethtool command parameter correctly before passing it to
drivers. This also means that whoever calls dev_ethtool_get_settings()
does not have to clean the ethtool command parameter. This function
also becomes an exported symbol instead of an inline.

All drivers visible to make allyesconfig under x86_64 have been
updated.

Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2 files changed, 4 insertions, 4 deletions

diff --git a/drivers/net/pch_gbe/pch_gbe_main.c b/drivers/net/pch_gbe/pch_gbe_main.c
index 4cc9872f5ec4..f3e4b0adae93 100644
--- a/drivers/net/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/pch_gbe/pch_gbe_main.c
@@ -888,12 +888,12 @@ static void pch_gbe_watchdog(unsigned long data)
         struct pch_gbe_adapter *adapter = (struct pch_gbe_adapter *)data;
         struct net_device *netdev = adapter->netdev;
         struct pch_gbe_hw *hw = &adapter->hw;
-        struct ethtool_cmd cmd;
 
         pr_debug("right now = %ld\n", jiffies);
 
         pch_gbe_update_stats(adapter);
         if ((mii_link_ok(&adapter->mii)) && (!netif_carrier_ok(netdev))) {
+                struct ethtool_cmd cmd = { .cmd = ETHTOOL_GSET };
                 netdev->tx_queue_len = adapter->tx_queue_len;
                 /* mii library handles link maintenance tasks */
                 if (mii_ethtool_gset(&adapter->mii, &cmd)) {
@@ -903,7 +903,7 @@ static void pch_gbe_watchdog(unsigned long data)
                                                 PCH_GBE_WATCHDOG_PERIOD));
                         return;
                 }
-                hw->mac.link_speed = cmd.speed;
+                hw->mac.link_speed = ethtool_cmd_speed(&cmd);
                 hw->mac.link_duplex = cmd.duplex;
                 /* Set the RGMII control. */
                 pch_gbe_set_rgmii_ctrl(adapter, hw->mac.link_speed,
@@ -913,7 +913,7 @@ static void pch_gbe_watchdog(unsigned long data)
                                  hw->mac.link_duplex);
                 netdev_dbg(netdev,
                            "Link is Up %d Mbps %s-Duplex\n",
-                           cmd.speed,
+                           hw->mac.link_speed,
                            cmd.duplex == DUPLEX_FULL ? "Full" : "Half");
                 netif_carrier_on(netdev);
                 netif_wake_queue(netdev);
diff --git a/drivers/net/pch_gbe/pch_gbe_phy.c b/drivers/net/pch_gbe/pch_gbe_phy.c
index 923a687acd30..9a8207f686fd 100644
--- a/drivers/net/pch_gbe/pch_gbe_phy.c
+++ b/drivers/net/pch_gbe/pch_gbe_phy.c
@@ -247,7 +247,7 @@ inline void pch_gbe_phy_set_rgmii(struct pch_gbe_hw *hw)
 void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw)
 {
         struct pch_gbe_adapter *adapter;
-        struct ethtool_cmd     cmd;
+        struct ethtool_cmd     cmd = { .cmd = ETHTOOL_GSET };
         int ret;
         u16 mii_reg;