diff options
author | Dhananjay Phadke <dhananjay@netxen.com> | 2008-03-17 22:59:51 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2008-03-25 23:16:21 -0400 |
commit | d1847a722e79bbfc557755d78f44d3e2c8ae5ea9 (patch) | |
tree | 44f2405079e4cfea2ddec6d7eb5fda1f00a1fb77 /drivers/net/netxen/netxen_nic_init.c | |
parent | ba53e6b4878e07411826312c59bfe49561594b6e (diff) |
netxen: fix rx dropped stats
Don't count rx dropped packets based on return value of netif_receive_skb(),
which is misleading.
Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
Tested-by: Vernon Mauery <mauery@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net/netxen/netxen_nic_init.c')
-rw-r--r-- | drivers/net/netxen/netxen_nic_init.c | 33 |
1 files changed, 1 insertions, 32 deletions
diff --git a/drivers/net/netxen/netxen_nic_init.c b/drivers/net/netxen/netxen_nic_init.c index fe646187aa86..d9713d933af5 100644 --- a/drivers/net/netxen/netxen_nic_init.c +++ b/drivers/net/netxen/netxen_nic_init.c | |||
@@ -1089,7 +1089,7 @@ static void netxen_process_rcv(struct netxen_adapter *adapter, int ctxid, | |||
1089 | skb = (struct sk_buff *)buffer->skb; | 1089 | skb = (struct sk_buff *)buffer->skb; |
1090 | 1090 | ||
1091 | if (likely(adapter->rx_csum && | 1091 | if (likely(adapter->rx_csum && |
1092 | netxen_get_sts_status(sts_data) == STATUS_CKSUM_OK)) { | 1092 | netxen_get_sts_status(sts_data) == STATUS_CKSUM_OK)) { |
1093 | adapter->stats.csummed++; | 1093 | adapter->stats.csummed++; |
1094 | skb->ip_summed = CHECKSUM_UNNECESSARY; | 1094 | skb->ip_summed = CHECKSUM_UNNECESSARY; |
1095 | } else | 1095 | } else |
@@ -1106,37 +1106,6 @@ static void netxen_process_rcv(struct netxen_adapter *adapter, int ctxid, | |||
1106 | skb->protocol = eth_type_trans(skb, netdev); | 1106 | skb->protocol = eth_type_trans(skb, netdev); |
1107 | 1107 | ||
1108 | ret = netif_receive_skb(skb); | 1108 | ret = netif_receive_skb(skb); |
1109 | |||
1110 | /* | ||
1111 | * RH: Do we need these stats on a regular basis. Can we get it from | ||
1112 | * Linux stats. | ||
1113 | */ | ||
1114 | switch (ret) { | ||
1115 | case NET_RX_SUCCESS: | ||
1116 | adapter->stats.uphappy++; | ||
1117 | break; | ||
1118 | |||
1119 | case NET_RX_CN_LOW: | ||
1120 | adapter->stats.uplcong++; | ||
1121 | break; | ||
1122 | |||
1123 | case NET_RX_CN_MOD: | ||
1124 | adapter->stats.upmcong++; | ||
1125 | break; | ||
1126 | |||
1127 | case NET_RX_CN_HIGH: | ||
1128 | adapter->stats.uphcong++; | ||
1129 | break; | ||
1130 | |||
1131 | case NET_RX_DROP: | ||
1132 | adapter->stats.updropped++; | ||
1133 | break; | ||
1134 | |||
1135 | default: | ||
1136 | adapter->stats.updunno++; | ||
1137 | break; | ||
1138 | } | ||
1139 | |||
1140 | netdev->last_rx = jiffies; | 1109 | netdev->last_rx = jiffies; |
1141 | 1110 | ||
1142 | rcv_desc->rcv_pending--; | 1111 | rcv_desc->rcv_pending--; |