aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/natsemi.c
diff options
context:
space:
mode:
authorDavid Decotigny <decot@google.com>2011-04-27 14:32:39 -0400
committerDavid S. Miller <davem@davemloft.net>2011-04-29 17:03:00 -0400
commit25db0338813a8915457636b1f6abe6a28fa73f8d (patch)
tree29ea39e45de1342beb4e3c58da0cfbc9915b617e /drivers/net/natsemi.c
parent8ae6daca85c8bbd6a32c382db5e2a2a989f8bed2 (diff)
ethtool: Use full 32 bit speed range in ethtool's set_settings
This makes sure the ethtool's set_settings() callback of network drivers don't ignore the 16 most significant bits when ethtool calls their set_settings(). All drivers compiled with make allyesconfig on x86_64 have been updated. Signed-off-by: David Decotigny <decot@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/natsemi.c')
-rw-r--r--drivers/net/natsemi.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index 1074231f0a0d..7633c67b7842 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -2908,7 +2908,8 @@ static int netdev_set_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
2908 return -EINVAL; 2908 return -EINVAL;
2909 } 2909 }
2910 } else if (ecmd->autoneg == AUTONEG_DISABLE) { 2910 } else if (ecmd->autoneg == AUTONEG_DISABLE) {
2911 if (ecmd->speed != SPEED_10 && ecmd->speed != SPEED_100) 2911 u32 speed = ethtool_cmd_speed(ecmd);
2912 if (speed != SPEED_10 && speed != SPEED_100)
2912 return -EINVAL; 2913 return -EINVAL;
2913 if (ecmd->duplex != DUPLEX_HALF && ecmd->duplex != DUPLEX_FULL) 2914 if (ecmd->duplex != DUPLEX_HALF && ecmd->duplex != DUPLEX_FULL)
2914 return -EINVAL; 2915 return -EINVAL;
@@ -2956,7 +2957,7 @@ static int netdev_set_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
2956 if (ecmd->advertising & ADVERTISED_100baseT_Full) 2957 if (ecmd->advertising & ADVERTISED_100baseT_Full)
2957 np->advertising |= ADVERTISE_100FULL; 2958 np->advertising |= ADVERTISE_100FULL;
2958 } else { 2959 } else {
2959 np->speed = ecmd->speed; 2960 np->speed = ethtool_cmd_speed(ecmd);
2960 np->duplex = ecmd->duplex; 2961 np->duplex = ecmd->duplex;
2961 /* user overriding the initial full duplex parm? */ 2962 /* user overriding the initial full duplex parm? */
2962 if (np->duplex == DUPLEX_HALF) 2963 if (np->duplex == DUPLEX_HALF)