ethtool: cosmetic: Use ethtool ethtool_cmd_speed API

This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.

For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.

All drivers compiled with make allyesconfig ion x86_64 have been
updated.

Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 3 deletions

diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index 7633c67b7842..b78be088c4ad 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -2820,7 +2820,7 @@ static int netdev_get_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
         u32 tmp;
 
         ecmd->port        = dev->if_port;
-        ecmd->speed       = np->speed;
+        ethtool_cmd_speed_set(ecmd, np->speed);
         ecmd->duplex      = np->duplex;
         ecmd->autoneg     = np->autoneg;
         ecmd->advertising = 0;
@@ -2878,9 +2878,9 @@ static int netdev_get_ecmd(struct net_device *dev, struct ethtool_cmd *ecmd)
                 tmp = mii_nway_result(
                         np->advertising & mdio_read(dev, MII_LPA));
                 if (tmp == LPA_100FULL || tmp == LPA_100HALF)
-                        ecmd->speed  = SPEED_100;
+                        ethtool_cmd_speed_set(ecmd, SPEED_100);
                 else
-                        ecmd->speed  = SPEED_10;
+                        ethtool_cmd_speed_set(ecmd, SPEED_10);
                 if (tmp == LPA_100FULL || tmp == LPA_10FULL)
                         ecmd->duplex = DUPLEX_FULL;
                 else