aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/mv643xx_eth.c
diff options
context:
space:
mode:
authorLennert Buytenhek <buytenh@wantstofly.org>2008-08-28 00:10:04 -0400
committerLennert Buytenhek <buytenh@marvell.com>2008-09-05 00:33:59 -0400
commitbefefe2177d4bca07a64a2410333388c063a6f7d (patch)
treefc2ede00fa008c6a12447b89f6a65de54b333c7d /drivers/net/mv643xx_eth.c
parent4fdeca3f4e7e35f6c19e87617c23fbb59dfb1a63 (diff)
mv643xx_eth: delete unused and uninteresting interrupt source mask bits
Delete a couple of unused and uninteresting interrupt source mask bits: - The receive resource underrun interrupt sources are uninteresting because if we are in out-of-memory mode, we are already dealing with the issue, and we don't need the hardware to remind us again that we are out of memory. - The LINK and PHY interrupt sources can be coalesced into one define, since we always use them together. - The transmit resource underrun interrupt source can be disabled since we never activate the head descriptor of a paged skb until the fragments are all activated, so transmit underrun during a packet should never happen. - The INT_EXT_TX_0 define is never used. Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Diffstat (limited to 'drivers/net/mv643xx_eth.c')
-rw-r--r--drivers/net/mv643xx_eth.c17
1 files changed, 6 insertions, 11 deletions
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index bd3ca470916b..e592fac87068 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -105,14 +105,11 @@ static char mv643xx_eth_driver_version[] = "1.3";
105#define INT_CAUSE(p) (0x0460 + ((p) << 10)) 105#define INT_CAUSE(p) (0x0460 + ((p) << 10))
106#define INT_TX_END_0 0x00080000 106#define INT_TX_END_0 0x00080000
107#define INT_TX_END 0x07f80000 107#define INT_TX_END 0x07f80000
108#define INT_RX 0x0007fbfc 108#define INT_RX 0x000003fc
109#define INT_EXT 0x00000002 109#define INT_EXT 0x00000002
110#define INT_CAUSE_EXT(p) (0x0464 + ((p) << 10)) 110#define INT_CAUSE_EXT(p) (0x0464 + ((p) << 10))
111#define INT_EXT_LINK 0x00100000 111#define INT_EXT_LINK_PHY 0x00110000
112#define INT_EXT_PHY 0x00010000 112#define INT_EXT_TX 0x000000ff
113#define INT_EXT_TX_ERROR_0 0x00000100
114#define INT_EXT_TX_0 0x00000001
115#define INT_EXT_TX 0x0000ffff
116#define INT_MASK(p) (0x0468 + ((p) << 10)) 113#define INT_MASK(p) (0x0468 + ((p) << 10))
117#define INT_MASK_EXT(p) (0x046c + ((p) << 10)) 114#define INT_MASK_EXT(p) (0x046c + ((p) << 10))
118#define TX_FIFO_URGENT_THRESHOLD(p) (0x0474 + ((p) << 10)) 115#define TX_FIFO_URGENT_THRESHOLD(p) (0x0474 + ((p) << 10))
@@ -1815,11 +1812,11 @@ static irqreturn_t mv643xx_eth_irq(int irq, void *dev_id)
1815 int_cause_ext = 0; 1812 int_cause_ext = 0;
1816 if (int_cause & INT_EXT) { 1813 if (int_cause & INT_EXT) {
1817 int_cause_ext = rdl(mp, INT_CAUSE_EXT(mp->port_num)) 1814 int_cause_ext = rdl(mp, INT_CAUSE_EXT(mp->port_num))
1818 & (INT_EXT_LINK | INT_EXT_PHY | INT_EXT_TX); 1815 & (INT_EXT_LINK_PHY | INT_EXT_TX);
1819 wrl(mp, INT_CAUSE_EXT(mp->port_num), ~int_cause_ext); 1816 wrl(mp, INT_CAUSE_EXT(mp->port_num), ~int_cause_ext);
1820 } 1817 }
1821 1818
1822 if (int_cause_ext & (INT_EXT_PHY | INT_EXT_LINK)) 1819 if (int_cause_ext & INT_EXT_LINK_PHY)
1823 handle_link_event(mp); 1820 handle_link_event(mp);
1824 1821
1825 /* 1822 /*
@@ -2059,9 +2056,7 @@ static int mv643xx_eth_open(struct net_device *dev)
2059 set_rx_coal(mp, 0); 2056 set_rx_coal(mp, 0);
2060 set_tx_coal(mp, 0); 2057 set_tx_coal(mp, 0);
2061 2058
2062 wrl(mp, INT_MASK_EXT(mp->port_num), 2059 wrl(mp, INT_MASK_EXT(mp->port_num), INT_EXT_LINK_PHY | INT_EXT_TX);
2063 INT_EXT_LINK | INT_EXT_PHY | INT_EXT_TX);
2064
2065 wrl(mp, INT_MASK(mp->port_num), INT_TX_END | INT_RX | INT_EXT); 2060 wrl(mp, INT_MASK(mp->port_num), INT_TX_END | INT_RX | INT_EXT);
2066 2061
2067 return 0; 2062 return 0;