diff options
author | Joe Perches <joe@perches.com> | 2010-08-11 03:02:48 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-08-17 20:45:14 -0400 |
commit | baeb2ffab4e67bb9174e6166e070a9a8ec94b0f6 (patch) | |
tree | 08259e966cc0cacc58ed58a4865fe861cc255241 /drivers/net/mlx4 | |
parent | 5a68d5ee000bb784c4856391b4861739c8bbd341 (diff) |
drivers/net: Convert unbounded kzalloc calls to kcalloc
These changes may be slightly safer in some instances.
There are other kzalloc calls with a multiply, but those
calls are typically "small fixed #" * sizeof(some pointer)"
and those are not converted.
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/mlx4')
-rw-r--r-- | drivers/net/mlx4/alloc.c | 2 | ||||
-rw-r--r-- | drivers/net/mlx4/en_rx.c | 2 | ||||
-rw-r--r-- | drivers/net/mlx4/profile.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/mlx4/alloc.c b/drivers/net/mlx4/alloc.c index 8c8515619b8e..537997f9443e 100644 --- a/drivers/net/mlx4/alloc.c +++ b/drivers/net/mlx4/alloc.c | |||
@@ -188,7 +188,7 @@ int mlx4_buf_alloc(struct mlx4_dev *dev, int size, int max_direct, | |||
188 | buf->nbufs = (size + PAGE_SIZE - 1) / PAGE_SIZE; | 188 | buf->nbufs = (size + PAGE_SIZE - 1) / PAGE_SIZE; |
189 | buf->npages = buf->nbufs; | 189 | buf->npages = buf->nbufs; |
190 | buf->page_shift = PAGE_SHIFT; | 190 | buf->page_shift = PAGE_SHIFT; |
191 | buf->page_list = kzalloc(buf->nbufs * sizeof *buf->page_list, | 191 | buf->page_list = kcalloc(buf->nbufs, sizeof(*buf->page_list), |
192 | GFP_KERNEL); | 192 | GFP_KERNEL); |
193 | if (!buf->page_list) | 193 | if (!buf->page_list) |
194 | return -ENOMEM; | 194 | return -ENOMEM; |
diff --git a/drivers/net/mlx4/en_rx.c b/drivers/net/mlx4/en_rx.c index 8e2fcb7103c3..efc3fad468db 100644 --- a/drivers/net/mlx4/en_rx.c +++ b/drivers/net/mlx4/en_rx.c | |||
@@ -322,7 +322,7 @@ int mlx4_en_create_rx_ring(struct mlx4_en_priv *priv, | |||
322 | ring->lro.ip_summed_aggr = CHECKSUM_UNNECESSARY; | 322 | ring->lro.ip_summed_aggr = CHECKSUM_UNNECESSARY; |
323 | ring->lro.max_desc = mdev->profile.num_lro; | 323 | ring->lro.max_desc = mdev->profile.num_lro; |
324 | ring->lro.max_aggr = MAX_SKB_FRAGS; | 324 | ring->lro.max_aggr = MAX_SKB_FRAGS; |
325 | ring->lro.lro_arr = kzalloc(mdev->profile.num_lro * | 325 | ring->lro.lro_arr = kcalloc(mdev->profile.num_lro, |
326 | sizeof(struct net_lro_desc), | 326 | sizeof(struct net_lro_desc), |
327 | GFP_KERNEL); | 327 | GFP_KERNEL); |
328 | if (!ring->lro.lro_arr) { | 328 | if (!ring->lro.lro_arr) { |
diff --git a/drivers/net/mlx4/profile.c b/drivers/net/mlx4/profile.c index 5caf0115fa5b..e749f82865fe 100644 --- a/drivers/net/mlx4/profile.c +++ b/drivers/net/mlx4/profile.c | |||
@@ -85,7 +85,7 @@ u64 mlx4_make_profile(struct mlx4_dev *dev, | |||
85 | struct mlx4_resource tmp; | 85 | struct mlx4_resource tmp; |
86 | int i, j; | 86 | int i, j; |
87 | 87 | ||
88 | profile = kzalloc(MLX4_RES_NUM * sizeof *profile, GFP_KERNEL); | 88 | profile = kcalloc(MLX4_RES_NUM, sizeof(*profile), GFP_KERNEL); |
89 | if (!profile) | 89 | if (!profile) |
90 | return -ENOMEM; | 90 | return -ENOMEM; |
91 | 91 | ||