diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2009-09-03 06:39:43 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-09-03 23:02:11 -0400 |
commit | 7ab0f2736bfe137a82a7084bbfb5f809da95cabd (patch) | |
tree | e305ec96eceebb285efee4b6fd307822ab257fe6 /drivers/net/mdio.c | |
parent | aae5e7c30fc660c50dfecbdd745799b05af90f01 (diff) |
netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/mdio.c')
-rw-r--r-- | drivers/net/mdio.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/mdio.c b/drivers/net/mdio.c index 7d2e610f14ff..21f8754fcf4c 100644 --- a/drivers/net/mdio.c +++ b/drivers/net/mdio.c | |||
@@ -380,10 +380,7 @@ int mdio_mii_ioctl(const struct mdio_if_info *mdio, | |||
380 | cmd = SIOCGMIIREG; | 380 | cmd = SIOCGMIIREG; |
381 | break; | 381 | break; |
382 | case SIOCGMIIREG: | 382 | case SIOCGMIIREG: |
383 | break; | ||
384 | case SIOCSMIIREG: | 383 | case SIOCSMIIREG: |
385 | if (!capable(CAP_NET_ADMIN)) | ||
386 | return -EPERM; | ||
387 | break; | 384 | break; |
388 | default: | 385 | default: |
389 | return -EOPNOTSUPP; | 386 | return -EOPNOTSUPP; |