ethtool: cosmetic: Use ethtool ethtool_cmd_speed API

This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.

For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.

All drivers compiled with make allyesconfig ion x86_64 have been
updated.

Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 12 insertions, 8 deletions

diff --git a/drivers/net/mdio.c b/drivers/net/mdio.c
index f2d10abd0403..16fbb11d92ac 100644
--- a/drivers/net/mdio.c
+++ b/drivers/net/mdio.c
@@ -188,6 +188,7 @@ void mdio45_ethtool_gset_npage(const struct mdio_if_info *mdio,
                                u32 npage_adv, u32 npage_lpa)
 {
         int reg;
+        u32 speed;
 
         ecmd->transceiver = XCVR_INTERNAL;
         ecmd->phy_address = mdio->prtad;
@@ -290,33 +291,36 @@ void mdio45_ethtool_gset_npage(const struct mdio_if_info *mdio,
                 if (modes & (ADVERTISED_10000baseT_Full |
                              ADVERTISED_10000baseKX4_Full |
                              ADVERTISED_10000baseKR_Full)) {
-                        ecmd->speed = SPEED_10000;
+                        speed = SPEED_10000;
                         ecmd->duplex = DUPLEX_FULL;
                 } else if (modes & (ADVERTISED_1000baseT_Full |
                                     ADVERTISED_1000baseT_Half |
                                     ADVERTISED_1000baseKX_Full)) {
-                        ecmd->speed = SPEED_1000;
+                        speed = SPEED_1000;
                         ecmd->duplex = !(modes & ADVERTISED_1000baseT_Half);
                 } else if (modes & (ADVERTISED_100baseT_Full |
                                     ADVERTISED_100baseT_Half)) {
-                        ecmd->speed = SPEED_100;
+                        speed = SPEED_100;
                         ecmd->duplex = !!(modes & ADVERTISED_100baseT_Full);
                 } else {
-                        ecmd->speed = SPEED_10;
+                        speed = SPEED_10;
                         ecmd->duplex = !!(modes & ADVERTISED_10baseT_Full);
                 }
         } else {
                 /* Report forced settings */
                 reg = mdio->mdio_read(mdio->dev, mdio->prtad, MDIO_MMD_PMAPMD,
                                       MDIO_CTRL1);
-                ecmd->speed = (((reg & MDIO_PMA_CTRL1_SPEED1000) ? 100 : 1) *
-                               ((reg & MDIO_PMA_CTRL1_SPEED100) ? 100 : 10));
+                speed = (((reg & MDIO_PMA_CTRL1_SPEED1000) ? 100 : 1)
+                         * ((reg & MDIO_PMA_CTRL1_SPEED100) ? 100 : 10));
                 ecmd->duplex = (reg & MDIO_CTRL1_FULLDPLX ||
-                                ecmd->speed == SPEED_10000);
+                                speed == SPEED_10000);
         }
 
+        ethtool_cmd_speed_set(ecmd, speed);
+
         /* 10GBASE-T MDI/MDI-X */
-        if (ecmd->port == PORT_TP && ecmd->speed == SPEED_10000) {
+        if (ecmd->port == PORT_TP
+            && (ethtool_cmd_speed(ecmd) == SPEED_10000)) {
                 switch (mdio->mdio_read(mdio->dev, mdio->prtad, MDIO_MMD_PMAPMD,
                                         MDIO_PMA_10GBT_SWAPPOL)) {
                 case MDIO_PMA_10GBT_SWAPPOL_ABNX | MDIO_PMA_10GBT_SWAPPOL_CDNX: