[netdrvr] irq handler minor cleanups in several drivers

* use irq_handler_t where appropriate

* no need to use 'irq' function arg, its already stored in a data struct

* rename irq handler 'irq' argument to 'dummy', where the function
  has been analyzed and proven not to use its first argument.

* remove always-false "dev_id == NULL" test from irq handlers

* remove pointless casts from void*

* declance: irq argument is not const

* add KERN_xxx printk prefix

* fix minor whitespace weirdness

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

1 files changed, 4 insertions, 5 deletions

diff --git a/drivers/net/lp486e.c b/drivers/net/lp486e.c
index c5095ecd8b11..0eff1a00c43c 100644
--- a/drivers/net/lp486e.c
+++ b/drivers/net/lp486e.c
@@ -1144,14 +1144,13 @@ i596_handle_CU_completion(struct net_device *dev,
 }
 
 static irqreturn_t
-i596_interrupt (int irq, void *dev_instance) {
-        struct net_device *dev = (struct net_device *) dev_instance;
-        struct i596_private *lp;
+i596_interrupt (int irq, void *dev_instance)
+{
+        struct net_device *dev = dev_instance;
+        struct i596_private *lp = dev->priv;
         unsigned short status, ack_cmd = 0;
         int frames_in = 0;
 
-        lp = (struct i596_private *) dev->priv;
-
         /*
          * The 82596 examines the command, performs the required action,
          * and then clears the SCB command word.