[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 8 insertions, 10 deletions

diff --git a/drivers/net/lib82596.c b/drivers/net/lib82596.c
index afa4638052a2..ffaa14f2cd01 100644
--- a/drivers/net/lib82596.c
+++ b/drivers/net/lib82596.c
@@ -1034,15 +1034,12 @@ static int i596_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
 static void print_eth(unsigned char *add, char *str)
 {
-        int i;
+        DECLARE_MAC_BUF(mac);
+        DECLARE_MAC_BUF(mac2);
 
-        printk(KERN_DEBUG "i596 0x%p, ", add);
-        for (i = 0; i < 6; i++)
-                printk(" %02X", add[i + 6]);
-        printk(" -->");
-        for (i = 0; i < 6; i++)
-                printk(" %02X", add[i]);
-        printk(" %02X%02X, %s\n", add[12], add[13], str);
+        printk(KERN_DEBUG "i596 0x%p, %s --> %s %02X%02X, %s\n",
+               add, print_mac(mac, add + 6), print_mac(mac2, add),
+               add[12], add[13], str);
 }
 
 static int __devinit i82596_probe(struct net_device *dev)
@@ -1352,6 +1349,7 @@ static void set_multicast_list(struct net_device *dev)
         struct i596_private *lp = netdev_priv(dev);
         struct i596_dma *dma = lp->dma;
         int config = 0, cnt;
+        DECLARE_MAC_BUF(mac);
 
         DEB(DEB_MULTI,
             printk(KERN_DEBUG
@@ -1415,8 +1413,8 @@ static void set_multicast_list(struct net_device *dev)
                         if (i596_debug > 1)
                                 DEB(DEB_MULTI,
                                     printk(KERN_DEBUG
-                                           "%s: Adding address %02x:%02x:%02x:%02x:%02x:%02x\n",
-                                           dev->name, cp[0], cp[1], cp[2], cp[3], cp[4], cp[5]));
+                                           "%s: Adding address %s\n",
+                                           dev->name, print_mac(mac, cp)));
                 }
                 DMA_WBACK_INV(dev, &dma->mc_cmd, sizeof(struct mc_cmd));
                 i596_add_cmd(dev, &cmd->cmd);