diff options
author | Patrick McHardy <kaber@trash.net> | 2008-07-16 23:16:14 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-07-16 23:16:14 -0400 |
commit | 78ed11a56bd8679aa6d51eb36b448342c59a7824 (patch) | |
tree | d5feb0f95f0002841d4d099aaac9fecb640bc3b5 /drivers/net/ixgbe | |
parent | 746b9f0228a1c607b3db67c80da1c2a963321926 (diff) |
netdrv intel: always enable VLAN filtering except in promiscous mode
Currently VLAN filtering is enabled when the first VLAN is added.
Obviously before that there's no point in receiving any VLAN packets.
Now that we disable VLAN filtering in promiscous mode, we can keep
the VLAN filters enabled the remaining time.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ixgbe')
-rw-r--r-- | drivers/net/ixgbe/ixgbe_main.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index afe3a1cdfdbd..7d8bf94d3783 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c | |||
@@ -1575,8 +1575,6 @@ static void ixgbe_vlan_rx_register(struct net_device *netdev, | |||
1575 | /* enable VLAN tag insert/strip */ | 1575 | /* enable VLAN tag insert/strip */ |
1576 | ctrl = IXGBE_READ_REG(&adapter->hw, IXGBE_VLNCTRL); | 1576 | ctrl = IXGBE_READ_REG(&adapter->hw, IXGBE_VLNCTRL); |
1577 | ctrl |= IXGBE_VLNCTRL_VME; | 1577 | ctrl |= IXGBE_VLNCTRL_VME; |
1578 | if (!(netdev->flags & IFF_PROMISC)) | ||
1579 | ctrl |= IXGBE_VLNCTRL_VFE; | ||
1580 | ctrl &= ~IXGBE_VLNCTRL_CFIEN; | 1578 | ctrl &= ~IXGBE_VLNCTRL_CFIEN; |
1581 | IXGBE_WRITE_REG(&adapter->hw, IXGBE_VLNCTRL, ctrl); | 1579 | IXGBE_WRITE_REG(&adapter->hw, IXGBE_VLNCTRL, ctrl); |
1582 | } | 1580 | } |
@@ -1655,8 +1653,7 @@ static void ixgbe_set_multi(struct net_device *netdev) | |||
1655 | } else { | 1653 | } else { |
1656 | fctrl &= ~(IXGBE_FCTRL_UPE | IXGBE_FCTRL_MPE); | 1654 | fctrl &= ~(IXGBE_FCTRL_UPE | IXGBE_FCTRL_MPE); |
1657 | } | 1655 | } |
1658 | if (adapter->vlgrp) | 1656 | fctrl |= IXGBE_VLNCTRL_VFE; |
1659 | fctrl |= IXGBE_VLNCTRL_VFE; | ||
1660 | } | 1657 | } |
1661 | 1658 | ||
1662 | IXGBE_WRITE_REG(hw, IXGBE_FCTRL, fctrl); | 1659 | IXGBE_WRITE_REG(hw, IXGBE_FCTRL, fctrl); |