diff options
author | David S. Miller <davem@davemloft.net> | 2008-01-16 01:43:24 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-17 04:49:29 -0500 |
commit | d2c7ddd6261eb885091cf6ddbcfae01f4216fb8e (patch) | |
tree | fefe1f6e6162e019be7a3f27788a395b1d121688 /drivers/net/ixgbe/ixgbe_main.c | |
parent | d8c89eb3a12f0da96d049bd515c7fa3702e511c5 (diff) |
[NET]: Fix TX timeout regression in Intel drivers.
This fixes a regression added by changeset
53e52c729cc169db82a6105fac7a166e10c2ec36 ("[NET]: Make ->poll()
breakout consistent in Intel ethernet drivers.")
As pointed out by Jesse Brandeburg, for three of the drivers edited
above there is breakout logic in the *_clean_tx_irq() code to prevent
running TX reclaim forever. If this occurs, we have to elide NAPI
poll completion or else those TX events will never be serviced.
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Diffstat (limited to 'drivers/net/ixgbe/ixgbe_main.c')
-rw-r--r-- | drivers/net/ixgbe/ixgbe_main.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index a56491617661..de3f45e4c5ae 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c | |||
@@ -1468,13 +1468,16 @@ static int ixgbe_clean(struct napi_struct *napi, int budget) | |||
1468 | struct ixgbe_adapter *adapter = container_of(napi, | 1468 | struct ixgbe_adapter *adapter = container_of(napi, |
1469 | struct ixgbe_adapter, napi); | 1469 | struct ixgbe_adapter, napi); |
1470 | struct net_device *netdev = adapter->netdev; | 1470 | struct net_device *netdev = adapter->netdev; |
1471 | int work_done = 0; | 1471 | int tx_cleaned = 0, work_done = 0; |
1472 | 1472 | ||
1473 | /* In non-MSIX case, there is no multi-Tx/Rx queue */ | 1473 | /* In non-MSIX case, there is no multi-Tx/Rx queue */ |
1474 | ixgbe_clean_tx_irq(adapter, adapter->tx_ring); | 1474 | tx_cleaned = ixgbe_clean_tx_irq(adapter, adapter->tx_ring); |
1475 | ixgbe_clean_rx_irq(adapter, &adapter->rx_ring[0], &work_done, | 1475 | ixgbe_clean_rx_irq(adapter, &adapter->rx_ring[0], &work_done, |
1476 | budget); | 1476 | budget); |
1477 | 1477 | ||
1478 | if (tx_cleaned) | ||
1479 | work_done = budget; | ||
1480 | |||
1478 | /* If budget not fully consumed, exit the polling mode */ | 1481 | /* If budget not fully consumed, exit the polling mode */ |
1479 | if (work_done < budget) { | 1482 | if (work_done < budget) { |
1480 | netif_rx_complete(netdev, napi); | 1483 | netif_rx_complete(netdev, napi); |