diff options
author | Emil Tantilov <emil.s.tantilov@intel.com> | 2010-05-13 13:33:00 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-05-14 00:07:32 -0400 |
commit | e433ea1fb03c10debf101019668b83abed041c24 (patch) | |
tree | e337d64fc7be738c1220b0e66fa4c1e5a5f4c552 /drivers/net/ixgbe/ixgbe_main.c | |
parent | e7874c996b8591f59d78efa519031dab5b58723b (diff) |
ixgbe: fix setting of promisc mode when using mac-vlans
Introduce uc_set_promisc flag to fix enabling of promisc mode
when exceeding the number of supported RAR entries.
Issue discovered by Ben Greear when using mac-vlans.
Reported-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ixgbe/ixgbe_main.c')
-rw-r--r-- | drivers/net/ixgbe/ixgbe_main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index d1a1868df817..15032c79e003 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c | |||
@@ -2952,7 +2952,7 @@ void ixgbe_set_rx_mode(struct net_device *netdev) | |||
2952 | fctrl = IXGBE_READ_REG(hw, IXGBE_FCTRL); | 2952 | fctrl = IXGBE_READ_REG(hw, IXGBE_FCTRL); |
2953 | 2953 | ||
2954 | if (netdev->flags & IFF_PROMISC) { | 2954 | if (netdev->flags & IFF_PROMISC) { |
2955 | hw->addr_ctrl.user_set_promisc = 1; | 2955 | hw->addr_ctrl.user_set_promisc = true; |
2956 | fctrl |= (IXGBE_FCTRL_UPE | IXGBE_FCTRL_MPE); | 2956 | fctrl |= (IXGBE_FCTRL_UPE | IXGBE_FCTRL_MPE); |
2957 | /* don't hardware filter vlans in promisc mode */ | 2957 | /* don't hardware filter vlans in promisc mode */ |
2958 | ixgbe_vlan_filter_disable(adapter); | 2958 | ixgbe_vlan_filter_disable(adapter); |
@@ -2960,11 +2960,11 @@ void ixgbe_set_rx_mode(struct net_device *netdev) | |||
2960 | if (netdev->flags & IFF_ALLMULTI) { | 2960 | if (netdev->flags & IFF_ALLMULTI) { |
2961 | fctrl |= IXGBE_FCTRL_MPE; | 2961 | fctrl |= IXGBE_FCTRL_MPE; |
2962 | fctrl &= ~IXGBE_FCTRL_UPE; | 2962 | fctrl &= ~IXGBE_FCTRL_UPE; |
2963 | } else { | 2963 | } else if (!hw->addr_ctrl.uc_set_promisc) { |
2964 | fctrl &= ~(IXGBE_FCTRL_UPE | IXGBE_FCTRL_MPE); | 2964 | fctrl &= ~(IXGBE_FCTRL_UPE | IXGBE_FCTRL_MPE); |
2965 | } | 2965 | } |
2966 | ixgbe_vlan_filter_enable(adapter); | 2966 | ixgbe_vlan_filter_enable(adapter); |
2967 | hw->addr_ctrl.user_set_promisc = 0; | 2967 | hw->addr_ctrl.user_set_promisc = false; |
2968 | } | 2968 | } |
2969 | 2969 | ||
2970 | IXGBE_WRITE_REG(hw, IXGBE_FCTRL, fctrl); | 2970 | IXGBE_WRITE_REG(hw, IXGBE_FCTRL, fctrl); |