aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ixgb
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2007-09-15 17:41:06 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-10-10 19:51:17 -0400
commit88d3aafdae5c5e1d2dd9489a5c8a24e29d335f2e (patch)
tree272ce75c30a170420ac8bbfd679c3faed9f9d20a /drivers/net/ixgb
parent09f75cd7bf13720738e6a196cc0107ce9a5bd5a0 (diff)
[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls
For the operations get-tx-csum get-sg get-tso get-ufo the default ethtool_op_xxx behavior is fine for all drivers, so we permit op==NULL to imply the default behavior. This provides a more uniform behavior across all drivers, eliminating ethtool(8) "ioctl not supported" errors on older drivers that had not been updated for the latest sub-ioctls. The ethtool_op_xxx() functions are left exported, in case anyone wishes to call them directly from a driver-private implementation -- a not-uncommon case. Should an ethtool_op_xxx() helper remain unused for a while, except by net/core/ethtool.c, we can un-export it at a later date. [ Resolved conflicts with set/get value ethtool patch... -DaveM ] Signed-off-by: Jeff Garzik <jeff@garzik.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ixgb')
-rw-r--r--drivers/net/ixgb/ixgb_ethtool.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ixgb/ixgb_ethtool.c b/drivers/net/ixgb/ixgb_ethtool.c
index 21d35bc53906..181b59dc1ac3 100644
--- a/drivers/net/ixgb/ixgb_ethtool.c
+++ b/drivers/net/ixgb/ixgb_ethtool.c
@@ -713,11 +713,9 @@ static const struct ethtool_ops ixgb_ethtool_ops = {
713 .set_rx_csum = ixgb_set_rx_csum, 713 .set_rx_csum = ixgb_set_rx_csum,
714 .get_tx_csum = ixgb_get_tx_csum, 714 .get_tx_csum = ixgb_get_tx_csum,
715 .set_tx_csum = ixgb_set_tx_csum, 715 .set_tx_csum = ixgb_set_tx_csum,
716 .get_sg = ethtool_op_get_sg,
717 .set_sg = ethtool_op_set_sg, 716 .set_sg = ethtool_op_set_sg,
718 .get_msglevel = ixgb_get_msglevel, 717 .get_msglevel = ixgb_get_msglevel,
719 .set_msglevel = ixgb_set_msglevel, 718 .set_msglevel = ixgb_set_msglevel,
720 .get_tso = ethtool_op_get_tso,
721 .set_tso = ixgb_set_tso, 719 .set_tso = ixgb_set_tso,
722 .get_strings = ixgb_get_strings, 720 .get_strings = ixgb_get_strings,
723 .phys_id = ixgb_phys_id, 721 .phys_id = ixgb_phys_id,