diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-09-02 16:07:41 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-09-02 22:06:22 -0400 |
commit | bc8acf2c8c3e43fcc192762a9f964b3e9a17748b (patch) | |
tree | e3a91392771a22390e59c24fcb7bad3045ce17d1 /drivers/net/ixgb | |
parent | 7162f6691e9d39d8d866574687cddb3f1ec65d72 (diff) |
drivers/net: avoid some skb->ip_summed initializations
fresh skbs have ip_summed set to CHECKSUM_NONE (0)
We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.
Introduce skb_checksum_none_assert() helper so that we keep this
assertion documented in driver sources.
Change most occurrences of :
skb->ip_summed = CHECKSUM_NONE;
by :
skb_checksum_none_assert(skb);
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ixgb')
-rw-r--r-- | drivers/net/ixgb/ixgb_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index 33c4ffe6e103..c2f6e71e1181 100644 --- a/drivers/net/ixgb/ixgb_main.c +++ b/drivers/net/ixgb/ixgb_main.c | |||
@@ -1905,7 +1905,7 @@ ixgb_rx_checksum(struct ixgb_adapter *adapter, | |||
1905 | */ | 1905 | */ |
1906 | if ((rx_desc->status & IXGB_RX_DESC_STATUS_IXSM) || | 1906 | if ((rx_desc->status & IXGB_RX_DESC_STATUS_IXSM) || |
1907 | (!(rx_desc->status & IXGB_RX_DESC_STATUS_TCPCS))) { | 1907 | (!(rx_desc->status & IXGB_RX_DESC_STATUS_TCPCS))) { |
1908 | skb->ip_summed = CHECKSUM_NONE; | 1908 | skb_checksum_none_assert(skb); |
1909 | return; | 1909 | return; |
1910 | } | 1910 | } |
1911 | 1911 | ||
@@ -1913,7 +1913,7 @@ ixgb_rx_checksum(struct ixgb_adapter *adapter, | |||
1913 | /* now look at the TCP checksum error bit */ | 1913 | /* now look at the TCP checksum error bit */ |
1914 | if (rx_desc->errors & IXGB_RX_DESC_ERRORS_TCPE) { | 1914 | if (rx_desc->errors & IXGB_RX_DESC_ERRORS_TCPE) { |
1915 | /* let the stack verify checksum errors */ | 1915 | /* let the stack verify checksum errors */ |
1916 | skb->ip_summed = CHECKSUM_NONE; | 1916 | skb_checksum_none_assert(skb); |
1917 | adapter->hw_csum_rx_error++; | 1917 | adapter->hw_csum_rx_error++; |
1918 | } else { | 1918 | } else { |
1919 | /* TCP checksum is good */ | 1919 | /* TCP checksum is good */ |