diff options
author | Jesse Brandeburg <jesse.brandeburg@intel.com> | 2009-04-21 14:42:05 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-04-22 03:47:54 -0400 |
commit | 4cb9be7ab47820a1fa747569f5f035a5f628c91b (patch) | |
tree | f272447c9bdc5b01578760f1c0f973a183f801b5 /drivers/net/ixgb | |
parent | bf98a82633b97fb638fcee0fae3c0de54d1f7b05 (diff) |
e1000/e1000e/igb/ixgb: do not use netif_wake_queue un-necessarily
It was pointed out that the Intel wired ethernet drivers do not need to
wake the tx queue since netif_carrier_on/off will take care of the qdisc
management in order to guarantee the correct handling of the transmit
routine enable state.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ixgb')
-rw-r--r-- | drivers/net/ixgb/ixgb_main.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index ff741ca110f5..cb9ecc48f6d0 100644 --- a/drivers/net/ixgb/ixgb_main.c +++ b/drivers/net/ixgb/ixgb_main.c | |||
@@ -266,6 +266,8 @@ ixgb_up(struct ixgb_adapter *adapter) | |||
266 | napi_enable(&adapter->napi); | 266 | napi_enable(&adapter->napi); |
267 | ixgb_irq_enable(adapter); | 267 | ixgb_irq_enable(adapter); |
268 | 268 | ||
269 | netif_wake_queue(netdev); | ||
270 | |||
269 | mod_timer(&adapter->watchdog_timer, jiffies); | 271 | mod_timer(&adapter->watchdog_timer, jiffies); |
270 | 272 | ||
271 | return 0; | 273 | return 0; |
@@ -1118,7 +1120,6 @@ ixgb_watchdog(unsigned long data) | |||
1118 | adapter->link_speed = 10000; | 1120 | adapter->link_speed = 10000; |
1119 | adapter->link_duplex = FULL_DUPLEX; | 1121 | adapter->link_duplex = FULL_DUPLEX; |
1120 | netif_carrier_on(netdev); | 1122 | netif_carrier_on(netdev); |
1121 | netif_wake_queue(netdev); | ||
1122 | } | 1123 | } |
1123 | } else { | 1124 | } else { |
1124 | if (netif_carrier_ok(netdev)) { | 1125 | if (netif_carrier_ok(netdev)) { |
@@ -1127,8 +1128,6 @@ ixgb_watchdog(unsigned long data) | |||
1127 | printk(KERN_INFO "ixgb: %s NIC Link is Down\n", | 1128 | printk(KERN_INFO "ixgb: %s NIC Link is Down\n", |
1128 | netdev->name); | 1129 | netdev->name); |
1129 | netif_carrier_off(netdev); | 1130 | netif_carrier_off(netdev); |
1130 | netif_stop_queue(netdev); | ||
1131 | |||
1132 | } | 1131 | } |
1133 | } | 1132 | } |
1134 | 1133 | ||